Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore-be: 모니터링 관련 환경 변수 추가 #224

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Original issue description

목적

모니터링 관련 환경 변수를 추가한다.

작업 세부사항

  • docker-compose.dev.yml 파일에 모니터링 관련 환경 변수 추가
  • CD docker workflow에 모니터링 관련 환경 변수 추가

참고 사항

아래의 별표줄 밑에 요구사항 ID만 작성해주세요. Prefix 금지!


DEV_MONITORING_02

closes #222

@github-actions github-actions bot added backend 백엔드 chore 빌드 업무 수정, 패키지 관리자 구성 등 업데이트, Production Code 변경 없음 labels Jul 31, 2024
@github-actions github-actions bot added this to the 스프린트 2.0 milestone Jul 31, 2024
Co-authored-by: cutehumanS2 <oddpinkjadeite@gmail.com>
Copy link
Contributor

@Dobby-Kim Dobby-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.
공백 추가를 위한 리뷰 간단하게 남겼으니 확인해주세요 :>

.github/workflows/be-cd_dev-docker.yml Outdated Show resolved Hide resolved
Copy link
Member

@Chocochip101 Chocochip101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제목 컨밴션에 맞게 수정해주세요.

@Dobby-Kim Dobby-Kim changed the title be-chore: 모니터링 관련 환경 변수 추가 chore-be: 모니터링 관련 환경 변수 추가 Aug 1, 2024
Co-authored-by: cutehumanS2 <oddpinkjadeite@gmail.com>
@xogns1514 xogns1514 marked this pull request as ready for review August 1, 2024 08:45
Copy link
Contributor Author

github-actions bot commented Aug 1, 2024

1722501923.785629

Copy link
Contributor Author

github-actions bot commented Aug 1, 2024

📌 Test Coverage Report

Overall Project 68.86%

There is no coverage information present for the Files changed

Copy link
Member

@Chocochip101 Chocochip101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xogns1514 xogns1514 removed the request for review from cutehumanS2 August 2, 2024 01:25
Copy link
Contributor

@Dobby-Kim Dobby-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@xogns1514 xogns1514 merged commit 73ccbfd into be/develop Aug 2, 2024
22 checks passed
@xogns1514 xogns1514 deleted the be-222-DEV_MONITORING_02 branch August 2, 2024 01:26
Chocochip101 pushed a commit that referenced this pull request Aug 12, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Leetaehoon <66353672+xogns1514@users.noreply.github.com>
Co-authored-by: cutehumanS2 <oddpinkjadeite@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend 백엔드 chore 빌드 업무 수정, 패키지 관리자 구성 등 업데이트, Production Code 변경 없음
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

3 participants