Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore-be: log file .gitignore 추가 #260

Merged
merged 3 commits into from
Aug 4, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 3, 2024

목적

log 모니터링 기능 적용으로 인한 불필요 log 파일 추적 제외

작업 세부사항

  • .gitignore 파일 수정

참고 사항

아래의 별표줄 밑에 요구사항 ID만 작성해주세요. Prefix 금지!


ADD_GIT_IGNORE_01

close #259

@github-actions github-actions bot added backend 백엔드 chore 빌드 업무 수정, 패키지 관리자 구성 등 업데이트, Production Code 변경 없음 labels Aug 3, 2024
@Dobby-Kim Dobby-Kim marked this pull request as ready for review August 3, 2024 09:36
Copy link
Contributor Author

github-actions bot commented Aug 3, 2024

1722677817.902579

Copy link
Contributor Author

github-actions bot commented Aug 3, 2024

📌 Test Coverage Report

Overall Project 68.92%

There is no coverage information present for the Files changed

Copy link
Contributor

@HyungHoKim00 HyungHoKim00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
backend/log 말고도 **/*.log 형식도 무시하게 만든 이유가 있나요?

@Dobby-Kim
Copy link
Contributor

@HyungHoKim00

👍 backend/log 말고도 **/*.log 형식도 무시하게 만든 이유가 있나요?

추후 log 전략과 설정에 따라 해당 디렉토리 이외에 log가 발생할 수도 있다는 생각에 우선 전역적으로 .log 파일을 무시하도록 했습니다 :>

Copy link
Contributor

@xogns1514 xogns1514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dobby-Kim Dobby-Kim merged commit 332b24c into be/develop Aug 4, 2024
@Dobby-Kim Dobby-Kim deleted the be-259-ADD_GIT_IGNORE_01 branch August 4, 2024 09:43
Chocochip101 pushed a commit that referenced this pull request Aug 12, 2024
Co-authored-by: Do Yeop Kim <113661364+Dobby-Kim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend 백엔드 chore 빌드 업무 수정, 패키지 관리자 구성 등 업데이트, Production Code 변경 없음
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

3 participants