feat-be: 지원서 수정 기능 구현 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📌 Test Coverage Report
|
|
1722864831.806699 |
xogns1514
approved these changes
Aug 6, 2024
cutehumanS2
requested changes
Aug 6, 2024
| // then | ||
| Optional<Applicant> changedApplicant = applicantRepository.findById(applicant.getId()); | ||
| assertAll( | ||
| () -> assertThat(changedApplicant).isNotNull(), |
There was a problem hiding this comment.
isPresent() vs isNotNull()
옵셔널이 비어있지 않은지 확인하려면 어느 것이 더 명확하다고 생각하시나요?
저는 전자요. ㅎ ㅎ 초코칩 생각도 궁금합니다.
There was a problem hiding this comment.
assertThat에서도 있는지 몰랐네요. isPresent는 Optional에 한정헤서 쓴다는 가정하에 있기에, 저도 전자가 가독성이 좋은것 같아요.
| String toChangeName = "도비"; | ||
| String toChangeEmail = "dev.dobby@gmail.com"; | ||
| String toChangePhone = "010111111111"; | ||
| applicantRepository.save(createApplicantDobby()); |
There was a problem hiding this comment.
음 save를 생략해도 된다고 생각하는데, 어떻게 생각하시나요?
cutehumanS2
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
관련 이슈
PR 체크리스트