refactor-be(Sub-Domain): Facade Service 도입을 위한 Controller가 없는 각 도메인 Service 기능 이동 #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
1722999359.358079 |
📌 Test Coverage Report
|
Chocochip101
requested changes
Aug 7, 2024
Comment on lines
+124
to
+125
| List<Question> nonChoiceTypeQuestions = questionRepository.saveAll(QuestionFixture.createNonChoiceTypeQuestions( | ||
| null)); |
There was a problem hiding this comment.
Suggested change
| List<Question> nonChoiceTypeQuestions = questionRepository.saveAll(QuestionFixture.createNonChoiceTypeQuestions( | |
| null)); | |
| List<Question> nonChoiceTypeQuestions = questionRepository.saveAll( | |
| QuestionFixture.createNonChoiceTypeQuestions(null) | |
| ); |
위 변경은 어떤가요?
There was a problem hiding this comment.
이것이 더 좋겠지만 코드 포맷팅을 적용하면 계속 file change가 발생하네요ㅠㅠ
우선은 저희가 전역적으로 적용한 컨벤션 포맷팅 기준으로 작성했습니다
backend/src/test/java/com/cruru/question/service/QuestionServiceTest.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/cruru/question/service/QuestionService.java
Outdated
Show resolved
Hide resolved
xogns1514
requested changes
Aug 7, 2024
backend/src/test/java/com/cruru/question/service/QuestionServiceTest.java
Outdated
Show resolved
Hide resolved
…acourse-teams/2024-cruru into be-284-FACADE_ADOPTION_01-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
상세설명
이슈 내용을 확인해주시기 바랍니다
PR 체크리스트
closes #287