refactor-be: 지원서 제출 시 응답 존재 유무 검증 추가 #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1724144221.731569 |
📌 Test Coverage Report
|
cutehumanS2
requested changes
Aug 21, 2024
Comment on lines
25
to
27
| if (replies.isEmpty()) { | ||
| throw new ReplyNotExistsException(); | ||
| } |
There was a problem hiding this comment.
모든 질문에 응답하지 않은 경우에만 예외를 던지는 것 맞나요?
ReplyNotExistsException의 MESSAGE("응답하지 않은 질문이 존재합니다.")만 보면,
질문 중 일부에 응답하지 않은 경우도 포함되는 것 같아요.
There was a problem hiding this comment.
질문 중 하나라도 응답하지 않는 경우 예외가 발생하도록 했는데, 필수 질문 중 하나라도 응답하지 않는 경우 예외가 발생하도록 수정해야겠네요.
cutehumanS2
approved these changes
Aug 21, 2024
| @@ -22,7 +22,7 @@ public class AnswerService { | |||
| @Transactional | |||
| public void saveAnswerReplies(AnswerCreateRequest answerCreateRequest, Question question, Applicant applicant) { | |||
| List<String> replies = answerCreateRequest.replies(); | |||
| if (replies.isEmpty()) { | |||
| if (question.getRequired() && replies.isEmpty()) { | |||
There was a problem hiding this comment.
Question에 isRequired()를 만들 수 있을 것 같아요.
There was a problem hiding this comment.
primitive type으로 변경하면서 사라졌습니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
VAL_ANS_RES_01
closes #555