Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor-be: url 필드 제거 및 응답에서 postId와 url을 applyFormId로 변경 #641

Merged
merged 7 commits into from
Sep 7, 2024
Merged

refactor-be: url 필드 제거 및 응답에서 postId와 url을 applyFormId로 변경 #641

merged 7 commits into from
Sep 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 5, 2024 •
edited by Chocochip101
Loading

목적

"공고를 생성한 이후, 공고로 가기를 클릭하면 404 응답을 반환한다.", "생성된 공고를 수정하는 창으로 이동하면, 404 응답을 반환한다." 버그를 수정합니다.

작업 세부사항

  • 대시보드 목록 조회 응답 body에서 url → applyFormId
  • applyFormId, postId를 applyFormId로 통일
  • 대시보드 생성 응답 body에서 url → applyFormId, postId → dashboardId
  • 프로세스 목록 조회 응답 body에서 url → applyFormId
  • applyForm url 필드 삭제

참고 사항

아래의 별표줄 밑에 요구사항 ID만 작성해주세요. Prefix 금지!

DASHBOARD_REF_01

closes #638

@github-actions github-actions bot added backend 백엔드 refactor 기존 코드 수정 labels Sep 5, 2024
@github-actions github-actions bot added this to the 스프린트 4.0 milestone Sep 5, 2024
@HyungHoKim00 HyungHoKim00 changed the title refactor-be: 대시보드 생성, 모든 대시보드 조회 API 수정 refactor-be: 대시보드 생성, 모든 대시보드 조회, 프로세스 목록 조회 API 수정 Sep 5, 2024
@HyungHoKim00 HyungHoKim00 changed the title refactor-be: 대시보드 생성, 모든 대시보드 조회, 프로세스 목록 조회 API 수정 refactor-be: url 필드 제거 및 응답에서 postId와 url을 applyFormId로 변경 Sep 5, 2024
@HyungHoKim00 HyungHoKim00 marked this pull request as ready for review September 5, 2024 05:21
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Sep 5, 2024

1725513733.058809

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Sep 5, 2024

📌 Test Coverage Report

Overall Project 76.99% ❌
Files changed 100% 🍏

File Coverage
DashboardFacade.java 100% 🍏
DashboardController.java 100% 🍏
DashboardPreviewResponse.java 100% 🍏
DashboardCreateResponse.java 100% 🍏
ProcessFacade.java 100% 🍏
ApplyFormService.java 100% 🍏
ProcessResponses.java 100% 🍏
ApplyForm.java 93.75% 🍏
ApplyFormFacade.java 90.59% 🍏
DataLoader.java 0% 🍏

Chocochip101
Chocochip101 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@Chocochip101 Chocochip101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL, baseUrl, postUrl 확인해봤는데, 모두 삭제되었네요 :)

수고하셨습니다!

Dobby-Kim
Dobby-Kim requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@Dobby-Kim Dobby-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니동
리뷰 드릴 부분이 간단하게 하나 밖에 없네요

확인해주세용

backend/src/main/java/com/cruru/dashboard/controller/DashboardController.java Outdated Show resolved Hide resolved
@HyungHoKim00 HyungHoKim00 merged commit c63c3da into be/develop Sep 7, 2024
10 checks passed
@HyungHoKim00 HyungHoKim00 deleted the be-638-DASHBOARD_REF_01 branch September 7, 2024 13:44
Dobby-Kim pushed a commit that referenced this pull request Sep 19, 2024
@github-actions @Dobby-Kim
refactor-be: url 필드 제거 및 응답에서 postId와 url을 applyFormId로 변경 (#641)
868281a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyungHoKim00 HyungHoKim00 HyungHoKim00 left review comments

@Dobby-Kim Dobby-Kim Dobby-Kim approved these changes

@Chocochip101 Chocochip101 Chocochip101 approved these changes

Assignees

@HyungHoKim00 HyungHoKim00

Labels
backend 백엔드 refactor 기존 코드 수정
Projects
2024-cruru
Status: 완료
Milestone
스프린트 4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Chocochip101 @Dobby-Kim @HyungHoKim00