Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat-be: 대시보드 생성 #65
feat-be: 대시보드 생성 #65
Changes from all commits
1e4ff30
cc465dd
883b23f
a1d2a48
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
논의를 통해 Fixture을 만드는 것을 고려해봅시다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixture는 Test Fixture에서 사용되는 용어인데, 의도한 바가 맞을까요?
https://docs.spring.io/spring-framework/reference/testing/testcontext-framework/fixture-di.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
서류지원, 합격 프로세스는 고정값이므로 static으로 두었습니다. 대시보드 생성시, 해당 프로세스의 내용을 뽑아와 저장하도록 했습니다. 이 방식보다 나은 방법이 있으시면 제안부탁드려요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static으로 정의하신 이유가 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
프로세스 2개가 고정값이여서, static으로 두었습니다.
name, decription 각각에 대해 상수화 하는 것보다, Process 객체 자체를 static으로 두는 것이 관리하기 편할 것 같다고 생각했습니다. 초코칩의 생각은 어떠신가용?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name, decription 각각에 대해 상수화와는 별개로, Process 객체로 관리해도 괜찮을 것 같아요.
러쉬는 어떤 측면에서 관리의 용이성을 느꼈나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아직 인스턴스로 관리했을 경우와 static으로 관리했을 경우 성능적 차이는 모르겠네요.. 고민해보겠습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분도 abstract class의 상위 test class를 만들어서 상속받아 전역적으로 test class를 만들면 좋을 것 같습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기존 processServiceTest에서 남아있던 데이터를 deleteAll()로 처리하는 것을 보고, 컨벤션 맞춰 작성했습니다.
테스트마다 데이터 격리 어떤방식으로 통일할지 얘기해보면 좋을 것 같습니다.