-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor-be: ApplyForm 제출 시 필수 질문 응답 여부 확인 로직 변경 #654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(action): 프로젝트-이슈-브랜치 자동화 초기 세팅 * feat(branch-create): 브랜치 및 PR 생성 규칙 적용 * fix(automation): github 토큰 인증 비활성화 * chore: 자동화 repo 타겟 branch를 master에서 main으로 변경 * refactor: issue - branch 자동화 과정 branch 명명 소스 변경 issue 제목 -> issue body * fix(automation): github 토큰 인증 활성화 * fix(automation): github 토큰 변경 * fix(automation): github 토큰 권한 추가 명시 * fix(automation): github 토큰 변경 * fix: 접근 projects명 수정 * fix: 접근 Option명 수정 * fix: 접근 Option명 수정 * chore: github-project-automation-plus version 변경 * chore: github-project-automation-plus version 변경 * chore: Projects Status명 영문화 * chore: Github Token 수정 * fix: PR 템플릿 설정 오타 수정 * refactor: Project (Classic) 기능 제거 후 Projects 기능으로 변경 * chore: actions app 버전 수정 * refactor: Projects 연동 기능 제거 * refactor: issue comment 메세지 변경 * fix: 변수 오타 수정 * refactor: 환경변수 scope 변경 * refactor: 환경변수 변경 * chore: PR url 타겟팅 환경변수 변경 * Update project-manage-issue.yml * test: 테스트용 code line 추가 * chore: 디버깅용 echo문 추가 * Update project-manage-issue.yml * Update project-manage-issue.yml * refactor: 변수 위치 수정 및 프로퍼티 경로 수정 * fix: 오류 수정 * refactor: PR Link 연결 Comment 기능 제거 * refactor: 미사용 전역 환경변수 제거 * refactor: Action bot 메세지 수정 및 Description 내용 PR 복사 기능 추가 * refactor: Action bot 메세지 수정 및 PR 링크 추가 * feat: github id와 slack id 매핑 * feat: PR review 요청 Slack mention 연동 기능 구현 * Update mention-to-slack.yml * chore: action trigger 수정 * refactor: 불필요 line 제거 및 트리거 추가 * refactor: workflow file명 변경 * chore: trigger 대상 브랜치 추가 * refactor: 슬랙 멘션 연동 기능 전면 수정 * chore: github - slack ID 매핑 정보 * chore: action trigger 추가 * chore: checkout 추가 * chore: 주석 제거 * fix: json 읽기 오류 대응 수정 * fix: 오류 수정 * chore: 마지막 쉼표 제거 * chore: 디버깅용 출력문 추가 * refactor: 전송 메세지 개행 추가 변경 * fix: json 형식 메세지 재수정 * refactor: 파일명 변경 및 발신 메세지 수정 * refactor: 발신 메세지에 발신인 포함 및 메세지 수정 * refactor: 디버깅 코드 제거 및 변수 변경 * fix: 발신, 수신자 Slack ID 지정 step 추가 * chore: 메세지 변경 * refactor: 미사용 환경설정 파일 삭제 * chore: comment 메세지 수정 * chore: 프로젝트 secrets와 동기화 * chore: Action 제목 수정 * refactor: 파일명 변경 * feat: 이슈 할당 시 진행 알림 Slack으로 전송 기능 구현
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Do Yeop Kim <113661364+Dobby-Kim@users.noreply.github.com>
# Conflicts: # backend/src/main/java/com/cruru/DataLoader.java
1726020572.493549 |
📌 Test Coverage Report
|
cutehumanS2
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제 환경에서는 gradle build 잘 됩니다.
approve 합니다.
Dobby-Kim
requested changes
Sep 12, 2024
backend/src/main/java/com/cruru/applyform/service/facade/ApplyFormFacade.java
Outdated
Show resolved
Hide resolved
Dobby-Kim
approved these changes
Sep 18, 2024
Dobby-Kim
added a commit
that referenced
this pull request
Sep 19, 2024
Co-authored-by: Kwoun Ki Ho <73146678+Chocochip101@users.noreply.github.com> Co-authored-by: Do Yeop Kim <113661364+Dobby-Kim@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HyungHoKim00 <hkim1109@naver.com> Co-authored-by: Kwoun Ki Ho <fingercut3822@gmail.com> Co-authored-by: Leetaehoon <66353672+xogns1514@users.noreply.github.com> Co-authored-by: cutehumanS2 <oddpinkjadeite@gmail.com> Co-authored-by: 김형호 <140397285+HyungHoKim00@users.noreply.github.com> Co-authored-by: 최가희 <60508828+cutehumanS2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
작업 세부사항
참고 사항
FORM_SUBMIT_03
closes #653