-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-be: web mvc 설정 변경 #684
Conversation
1726987391.515579 |
1726987394.855449 |
1726987397.014289 |
📌 Test Coverage Report
|
backend/src/main/java/com/cruru/global/AuthenticationInterceptor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
생각하지 못한 부분인데. 잘 짚어주셔서 감사합니닷!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
질문 하나만 남겨놓았습니다.
@@ -59,7 +59,7 @@ spring: | |||
enabled: true | |||
baseline-on-migrate: true | |||
jpa: | |||
show-sql: false | |||
show-sql: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev 환경에서의 쿼리 관측이 필요한 이유가 뭔가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다른 환경(dev, prod)에서 토큰이 없을 경우 applyform 변경이 가능한지 테스트하다가, dev 환경에서 쿼리가 없어서 불편함을 느껴서 추가했습니다.
dev 에는 디버깅 용으로 쿼리 출력을 해놔도 괜찮을거라고 생각했습니다.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kwoun Ki Ho <fingercut3822@gmail.com>
Original issue description
목적
현재 저희 MvcConfig의 설정은 아래와 같습니다.
위 설정의 문제는 다음 두 가지입니다.
.excludePathPatterns("/**/posts/**")
: posts와 관련된 api는 없습니다..excludePathPatterns("/**/applyform/**")
: applyform 조회를 위해 로그인 인터셉터에서 제외했지만, get post patch 모든 사람에게 열려 있습니다.작업 세부사항
.excludePathPatterns("/**/posts/**")
설정을 삭제한다./v1/applyform/{applyformId}
와 POST/v1/applyform/{applyformId}/submit
요청만 로그인 인터셉터를 안거치게 수정한다.참고 사항
MEMBER_LOGIN_03
closes #683