feat-be: Process 관련 API 쿼리 최적화 #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1727182982.605089 |
|
1727182983.872449 |
📌 Test Coverage Report
|
Chocochip101
changed the title
cutehumanS2
requested changes
Sep 25, 2024
backend/src/main/java/com/cruru/applicant/domain/repository/ApplicantRepository.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/cruru/applicant/domain/repository/ApplicantRepository.java
Outdated
Show resolved
Hide resolved
Comment on lines
+22
to
+24
| public ApplicantCardResponse toResponse() { | ||
| return new ApplicantCardResponse(id, name, createdAt, isRejected, (int) evaluationCount, averageScore); | ||
| } |
There was a problem hiding this comment.
다른 response 변환 로직은 facade나 service에 있는데,
이 변환 로직은 여기에 두신 이유가 궁금합니다(단순 궁금).
There was a problem hiding this comment.
이전까지는 facade, service 계층에 dto가 없어서요...? 그리고 controller 패키지에서 도메인을 참조해서요.
backend/src/test/java/com/cruru/applicant/domain/repository/ApplicantRepositoryTest.java
Show resolved
Hide resolved
| @@ -64,6 +64,10 @@ private Process toEvaluateProcess(ProcessCreateRequest request, Dashboard dashbo | |||
| return new Process(request.sequence(), request.name(), request.description(), ProcessType.EVALUATE, dashboard); | |||
| } | |||
|
|
|||
| public List<Process> findAllByDashboard(Long dashboardId) { | |||
There was a problem hiding this comment.
Suggested change
| public List<Process> findAllByDashboard(Long dashboardId) { | |
| public List<Process> findAllByDashboardId(Long dashboardId) { |
There was a problem hiding this comment.
다형성을 활용하기 위해 메서드명을 같게 했습니다. System.out.printlnString() 안하는 것처럼요.
혹시 어색하게 느껴지시나요?
There was a problem hiding this comment.
아뇨. ㅎ ㅎ 놓치신 줄 알았습니다.
다형성이 이유라면 수정하지 않아도 될 것 같아요.
xogns1514
approved these changes
Sep 25, 2024
| assertAll( | ||
| () -> assertThat(applicantCard.id()).isEqualTo(applicant.getId()), | ||
| () -> assertThat(applicantCard.name()).isEqualTo(applicant.getName()), | ||
| () -> assertThat(applicantCard.evaluationCount()).isEqualTo(0), |
There was a problem hiding this comment.
Suggested change
| () -> assertThat(applicantCard.evaluationCount()).isEqualTo(0), | |
| () -> assertThat(applicantCard.evaluationCount()).isZero(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
참고
관련 이슈
PR 체크리스트