feat-be: Dashboard 관련 API 쿼리 최적화 #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1727238446.045859 |
|
1727238448.570719 |
📌 Test Coverage Report
|
Chocochip101
changed the title
|
쿼리에 대한 테스트 추가하겠습니다. |
|
테스트 추가 완료했습니다. |
cutehumanS2
requested changes
Sep 25, 2024
Comment on lines
87
to
97
| // then | ||
| assertThat(applicants).hasSize(3); | ||
|
|
||
| assertAll( | ||
| () -> assertThat(applicants).contains(applicant1), | ||
| () -> assertThat(applicants).contains(applicant2), | ||
| () -> assertThat(applicants).contains(applicant3) | ||
| ); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Suggested change
| // then | |
| assertThat(applicants).hasSize(3); | |
| assertAll( | |
| () -> assertThat(applicants).contains(applicant1), | |
| () -> assertThat(applicants).contains(applicant2), | |
| () -> assertThat(applicants).contains(applicant3) | |
| ); | |
| } | |
| } | |
| // then | |
| assertThat(applicants).hasSize(3); | |
| assertThat(applicants).containsExactlyInAnyOrder(applicant1, applicant2, applicant3); | |
| } | |
| } |
이렇게 해도 괜찮지 않을까요? ?
cutehumanS2
approved these changes
Sep 25, 2024
xogns1514
approved these changes
Sep 25, 2024
Comment on lines
+16
to
+23
| @Query(""" | ||
| SELECT new com.cruru.dashboard.domain.DashboardApplyFormDto(d, a) | ||
| FROM ApplyForm a | ||
| JOIN FETCH a.dashboard d | ||
| JOIN FETCH d.club c | ||
| WHERE c.id = :clubId | ||
| """) | ||
| List<DashboardApplyFormDto> findAllByClub(@Param("clubId") Long clubId); |
…ERFORMANCE_01_05 # Conflicts: # backend/src/main/java/com/cruru/applicant/domain/repository/ApplicantRepository.java # backend/src/main/java/com/cruru/applyform/domain/repository/ApplyFormRepository.java # backend/src/test/java/com/cruru/applicant/domain/repository/ApplicantRepositoryTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
참고
관련 이슈
PR 체크리스트