feat-be: 이메일 인증 기능 구현 #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1729358679.500039 |
|
1729358681.903989 |
|
1729358683.242319 |
📌 Test Coverage Report
|
cutehumanS2
requested changes
Oct 21, 2024
| } | ||
|
|
||
| private void verify(String storedVerificationCode, String inputVerificationCode) { | ||
| if (storedVerificationCode == null) { |
There was a problem hiding this comment.
verify 로직을 VerificationCodeUtil로 옮기고 나니, 매개변수에 Optional을 달고 다녀야하는 문제점 때문에 적용하지 않았습니다.
HyungHoKim00
requested changes
Oct 21, 2024
|
|
||
| public void saveVerificationCode(String email, String verificationCode) { | ||
| redisTemplate.opsForValue() | ||
| .set(REDIS_PREFIX + email, verificationCode, VERIFICATION_CODE_EXPIRATION, TimeUnit.MINUTES); |
There was a problem hiding this comment.
10분인 이유가 있나요? 단순 궁금증입니다.
There was a problem hiding this comment.
10분이 인증하기에 적당한 시간이여서 설정했습니다. 더 좋은 시간이 있다면 반영하겠습니다~
| verify(storedVerificationCode, inputVerificationCode); | ||
| } | ||
|
|
||
| private void verify(String storedVerificationCode, String inputVerificationCode) { |
There was a problem hiding this comment.
이 메서드를 VerificationCodeUtil에 넣는건 어떠신가요?
| @Async | ||
| public void sendVerificationCode(String to, String verificationCode) { | ||
| try { | ||
| String subject = "인증 코드 안내"; |
There was a problem hiding this comment.
제목에 [크루루] 이런거 붙어있으면 좋겠어용
|
|
||
| @DisplayName("저장된 인증 코드가 없으면 예외가 발생한다.") | ||
| @Test | ||
| void verifyCode_verificationCodeNotFoundException() { |
There was a problem hiding this comment.
성공 테스트도 있으면 좋을 것 같아요.
변경사항
CI/CD 과정에서 테스트를 실행하면 레디스 서버가 없기 때문에 테스트가 실패하여 CI/CD가 불가능합니다. 따라서 MockBean으로 변경했습니다. 리뷰
EmailService에서 저장로직 없이 이메일만 보내는 로직만 존재하기에 테스트를 추가하지 않았습니다. |
cutehumanS2
approved these changes
Oct 21, 2024
Dobby-Kim
pushed a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kwoun Ki Ho <fingercut3822@gmail.com>
Dobby-Kim
pushed a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kwoun Ki Ho <fingercut3822@gmail.com>
Dobby-Kim
pushed a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kwoun Ki Ho <fingercut3822@gmail.com>
Merged
Dobby-Kim
added a commit
that referenced
this pull request
Oct 23, 2024
fix-be: applicantCard 조회 시 평가 점수와 갯수가 모든 프로세스에 대해 나오는 버그 수정 (#902) fix-be: 이메일 인증 시 이미 가입된 이메일은 예외를 던지도록 변경 (#906) feat-be: RTR 방식 Redis로 변경 (#889) feat-be: 이메일 전송 템플릿 적용 (#897) feat-be: 이메일 인증 후, 회원가입 이메일의 인증 여부 확인 (#882) refactor-be: 식별자에 Tsid 적용 (#856) feat-be: 이메일 전송 로직 중 지원자 일괄 조회 로직 구현 (#869) fix-be: github action의 Redis 환경 변수 추가 (#871) feat-be: 이메일 인증 기능 구현 (#848)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
EMAIL_VALID_01
closes #846