-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy v1.1 #88
Merged
Merged
deploy v1.1 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocochip101
requested review from
cutehumanS2,
xogns1514,
Dobby-Kim and
HyungHoKim00
July 19, 2024 08:23
Dobby-Kim
approved these changes
Jul 19, 2024
HyungHoKim00
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
U R the Best
cutehumanS2
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
xogns1514
approved these changes
Jul 19, 2024
Co-Authored-By: 김형호 <140397285+HyungHoKim00@users.noreply.github.com> Co-Authored-By: Kwoun Ki Ho <73146678+Chocochip101@users.noreply.github.com>
Co-Authored-By: 김형호 <140397285+HyungHoKim00@users.noreply.github.com> Co-Authored-By: Kwoun Ki Ho <73146678+Chocochip101@users.noreply.github.com>
* Create draft PR for #31 * feat: 프로세스 생성 Co-Authored-By: 김형호 <140397285+HyungHoKim00@users.noreply.github.com> Co-Authored-By: Kwoun Ki Ho <73146678+Chocochip101@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cutehumanS2 <oddpinkjadeite@gmail.com> Co-authored-by: 김형호 <140397285+HyungHoKim00@users.noreply.github.com> Co-authored-by: Kwoun Ki Ho <73146678+Chocochip101@users.noreply.github.com>
* Create draft PR for #49 * feat: 더미 데이터 추가 --------- Co-authored-by: HyungHoKim00 <hkim1109@naver.com>
* Create draft PR for #58 * chore: jacoco 설정 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kwoun Ki Ho <fingercut3822@gmail.com>
* Create draft PR for #51 * feat(Process): 프로세스 이름 검증 로직 Co-Authored-By: Leetaehoon <66353672+xogns1514@users.noreply.github.com> * refactor: DashboardNotFoundException 에러 메시지 변경 Co-Authored-By: Leetaehoon <66353672+xogns1514@users.noreply.github.com> * feat: 프로세스 최대 개수 검증 Co-Authored-By: Leetaehoon <66353672+xogns1514@users.noreply.github.com> * feat: 프로세스 삭제 시 검증 첫 번째 접수와 마지막 프로세스는 삭제 불가능 Co-Authored-By: Leetaehoon <66353672+xogns1514@users.noreply.github.com> * fix: 프로세스 이름 검증 정규식 변경 띄어쓰기 포함할 수 있도록 변경 Co-Authored-By: Leetaehoon <66353672+xogns1514@users.noreply.github.com> * refactor: 프로세스 생성 로직 변경 Co-Authored-By: Leetaehoon <66353672+xogns1514@users.noreply.github.com> Co-Authored-By: 김형호 <140397285+HyungHoKim00@users.noreply.github.com> * refactor: 접근 제어자 변경 * refactor: 테스트 value 변경 * refactor: DTO 필드 타입 변경 * refactor: 테스트 데이터 저장 구현 변경 * refactor: 검증 로직을 메서드로 분리 * style: 포매팅 * refactor: displayName 및 테스트 데이터 변경 * feat: 프로세스 삭제 시 검증 지원자가 존재하는 프로세스 삭제 불가능 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cutehumanS2 <oddpinkjadeite@gmail.com> Co-authored-by: Leetaehoon <66353672+xogns1514@users.noreply.github.com> Co-authored-by: 김형호 <140397285+HyungHoKim00@users.noreply.github.com>
* Create draft PR for #62 * feat: 지원자 기본 정보 조회 * chore(slack-alert): PR review 개별 comment 알림 기능 수정 * test: 테스트 문구 및 처리 방법 변경 * chore(slack-alert): PR review 완료, approve Slack 알림 기능 수정 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HyungHoKim00 <hkim1109@naver.com> Co-authored-by: Do Yeop Kim <113661364+Dobby-Kim@users.noreply.github.com>
* Create draft PR for #64 * feat(Dashboard): 대시보드 생성 기능 구현 - 대시보드 생성시 기본 프로세스 2개가 생성된다. - 서류지원 프로세스 - 합격 프로세스 * refactor(DashboardService): create 메서드 @transactional 추가 * refactor(DashboardControllerTest): 불필요한 코드 제거 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: leetaehoon <xogns1514@gmail.com>
* Create draft PR for #66 * feat: 평가 생성 * chore: spring validation 설정 * feat: 메서드 예외처리 응답 생성 * feat: body 검증 로직 * test: 외래키 무결성에 의한 테스트 깨짐 현상 수정 * refactor: 매직넘버 분리 * refactor: 메서드명 변경 * test: when&then 변경 * test: 불필요한 개행 제거 * refactor: 불필요한 괄호 제거 * test: deleteAllInBatch 적용 * test: get() 제거 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kwoun Ki Ho <fingercut3822@gmail.com>
* Create draft PR for #68 * feat: 프로세스 조회 응답에 지원자의 불합격 여부 포함 * refactor: 데이터 필드 값 변경 * refactor: 필드 타입 변경 * style: 컨벤션 적용 * test: 프로세스 조회 실패 컨트롤러 테스트 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cutehumanS2 <oddpinkjadeite@gmail.com>
* Create draft PR for #77 * feat: 평가 조회 * test: false 추가 * test: 일급컬랙션 변수명 변경 * refactor: DTO 변환 메서드 분리 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kwoun Ki Ho <fingercut3822@gmail.com>
* Create draft PR for #71 * feat: question, choice, answer, chosenResponse 엔티티 추가 * feat: 지원자 상세 정보 조회 기능 구현 * refactor: merge 이후 confilct 나는 부분 수정 * fix: 테스트가 동작하지 않는 부분 수정 * refactor: chosenResponse 제거 * refactor: 불필요한 코드 제거 및 변경 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HyungHoKim00 <hkim1109@naver.com>
* Create draft PR for #81 * refactor(DashboardService): return 타입 primitive type으로 변경 * refactor(Dashboard): BaseEntity 상속 * refactor(DashboardController): return type 변경 * feat: 동아리 생성 기능 구현 동아리 이름 - 최소 1자 이상 최대 32자 이하여야 한다. - 특수 문자를 허용한다(예: !, @, #, $, %, ^, &, *, (, )). - 숫자를 허용한다(0-9). - 띄어쓰기 허용 * refactor: 검증 메시지 추가 * refactor: db cleansing 메서드 수정 * feat: Club 생성날짜, 수정날짜 추가 * refactor: Club, Dashboard 생성날짜, 갱신날짜 제거 * style: 코드 포맷팅 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: leetaehoon <xogns1514@gmail.com>
* Create draft PR for #79 * test: 테스트 데이터에 지원자 불합격 여부 필드 추가 * feat: 프로세스 목록 조회 응답에 지원자의 평가자 수 필드 포함 * refactor: 메서드명 및 파라미터명 컨벤션 적용 * refactor: 테스트 코드 스타일 변경 * refactor: 메서드 반환 타입 변경 * refactor: DashboardApplicantDto 생성 로직 변경 * test: 실패하는 테스트 수정 * refactor: 대시보드 존재 여부 검증 로직 변경 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cutehumanS2 <oddpinkjadeite@gmail.com> Co-authored-by: 최가희 <60508828+cutehumanS2@users.noreply.github.com>
* Create draft PR for #84 * chore: CORS 허용 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kwoun Ki Ho <fingercut3822@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
3000포트 CORS가 허용된 버전을 배포합니다.
참고 사항
PR 체크리스트