Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge-fe: Bug Fix v2.1.1 (24.10.24) #923

Merged
merged 2 commits into from
Oct 24, 2024
Merged

merge-fe: Bug Fix v2.1.1 (24.10.24) #923

merged 2 commits into from
Oct 24, 2024

Conversation

lurgi
Copy link
Contributor

@lurgi lurgi commented Oct 23, 2024

작업 내용

  • 해당 버그 원인은 모르겠음.
  • input의 font-size를 없애거나, width를 100%로 변경시 해당 버그가 해결됨.
스크린샷 2024-10-24 오전 8 39 11 스크린샷 2024-10-24 오전 8 38 47
  • width값을 수정하는 것으로 변경. 공통 컴포넌트를 건드렸을 경우 사이드 이펙트가 발생할 것이라 생각하여 버그가 난 부분에만 적용하였습니다.

  • flex-grow로 해결. flex박스 문제. 아르 감사합니다👍

관련 이슈

PR 체크리스트

  • 테스트는 모두 통과했나요?
  • 빌드는 성공했나요?
  • 코드 포맷팅을 진행했나요?
  • PR 내부의 예시는 삭제하셨나요?

@lurgi lurgi self-assigned this Oct 23, 2024
Copy link
Contributor

1729727562.968539

Copy link
Contributor

1729727563.806909

@lurgi lurgi changed the title fix-fe: 회원가입 페이지 크롬 이외 브라우저 컴포넌트 레이아웃 깨짐 수정 merge-fe: 10.24 Bug Fix 2.1.1 Oct 23, 2024
@lurgi lurgi changed the title merge-fe: 10.24 Bug Fix 2.1.1 merge-fe: Bug Fix v2.1.1 (24.10.24) Oct 23, 2024
Copy link
Contributor

@seongjinme seongjinme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS는 늘 간편하면서도 어렵고 그런 것 같아요. 고생하셨습니다!

Comment on lines +14 to +17
& > div:first-child {
min-width: 150px;
flex-grow: 1;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flex-grow 속성을 사용하셨군요 👍

@lurgi lurgi merged commit 9cc426a into fe/main Oct 24, 2024
9 of 10 checks passed
@lurgi lurgi deleted the 922-fe-FIX_SIGN_UP_COM branch October 24, 2024 01:48
@lurgi lurgi added this to the 스프린트 6.0 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

3 participants