feat-be: 이메일 템플릿 기능 추가 #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1736759007.661069 |
cutehumanS2
approved these changes
Jan 14, 2025
Comment on lines
69
to
76
| private String applyTemplate(String content, Club from, Applicant to) { | ||
| content = EmailKeyword.APPLICANT_NAME.replace(content, to.getName()); | ||
| content = EmailKeyword.CLUB_NAME.replace(content, from.getName()); | ||
| content = EmailKeyword.APPLY_FORM_TITLE.replace(content, | ||
| applyFormService.findByDashboard(to.getDashboard()).getTitle()); | ||
| content = EmailKeyword.PROCESS_NAME.replace(content, to.getProcess().getName()); | ||
| return content; | ||
| } |
There was a problem hiding this comment.
[가벼운 제안]
- 계속 String이 새로 생성되는 걸로 판단되는데, StringBuilder/StringBuffer를 쓰는 게 성능이 좀 더 좋지 않을까요? ? 지금은 치환값이 4개이고 변동될 여지도 딱히 없을 거 같아서 반드시 반영하실 필요는 없습니다~ ㅎㅎ
- 뭔가 치환할 값들을 Map으로 묶어 인자로 전달하고, 루프로 한번에 처리할 수 있을 것 같기도 합니다.
Dobby-Kim
requested changes
Jan 15, 2025
Comment on lines
+4
to
+7
| APPLICANT_NAME("{AP_NAME}"), | ||
| CLUB_NAME("{CL_NAME}"), | ||
| APPLY_FORM_TITLE("{RC_TITLE}"), | ||
| PROCESS_NAME("{RC_STEP}"), |
There was a problem hiding this comment.
요부분은 프론트와 협의해서 정해진 정규식인가요?
맞다면 각각의 키워드가 어떤 의미를 가지는지 설명해주실 수 있을까요오
There was a problem hiding this comment.
맞습니다! 회의때만 말하고 공유사항에 적질 않았네요 ㅎㅎ.. 각각 아래의 줄임말입니다.
지원자 이름 -> APPLICANT_NAME
동아리 이름 -> CLUB_NAME
공고 이름 -> RECRUITMENT_POST_TITLE
모집 단계 -> RECRUITMENT_STEP
| import org.springframework.web.multipart.MultipartFile; | ||
|
|
||
| @Service | ||
| @Transactional(readOnly = true) |
There was a problem hiding this comment.
외부 연동구간이 많은 EmailFacade에서는 의도하여 @Transactional을 사용하지 않은 것으로 알고 있는데 혹시 제가 잘못 알고 있는 걸까요?
이 부분 확인해주시면 감사하겠습니다: >
There was a problem hiding this comment.
이 부분은 제가 실수했네요 ㅜㅜ. 템플릿이 들어가는 시점에서 데이터의 일관성을 보장하기 위해 추가했었어요. 수정했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
EMAIL_TEMPLATE_01
closes #987