[AN] feat: 내 강아지 상세 화면 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinuemong
previously approved these changes
Jul 19, 2024
|
|
||
| @BindingAdapter("genderDrawable") | ||
| fun ImageView.bindGenderDrawable(gender: String) { | ||
| if (gender == "수컷") { |
There was a problem hiding this comment.
enum 클래스로 분리한거 아닌가요 !!! 활용하면 좋을 것 가타요
| } | ||
|
|
||
| @BindingAdapter("dogSize") | ||
| fun TextView.bindDogSize(sizeType: String) { |
There was a problem hiding this comment.
이런 경우에도 예외를 전파할 수 있나요?
else -> error()
There was a problem hiding this comment.
음 전파를 못할 것 같습니다. 이부분은 같이 고민해봐요!!
| private val _uiState: MutableLiveData<DogDetailUiState> = MutableLiveData(DogDetailUiState()) | ||
| val uiState: LiveData<DogDetailUiState> get() = _uiState | ||
|
|
||
| private val _currentPage: MutableLiveData<Int> = MutableLiveData(Int.MAX_VALUE / 2) |
There was a problem hiding this comment.
Int.MAX_VALUE / 2 무슨 의미인가용?
There was a problem hiding this comment.
중간 페이지라는 의미입니다. 코드 이해를 돕기위해 변수를 하나 만들었습니다!!
gaeun5744
previously approved these changes
Jul 19, 2024
Comment on lines
+14
to
+20
| @BindingAdapter("setUpIndicator") | ||
| fun LinearLayout.bindSetUpIndicator(size: Int) { | ||
| removeAllViews() | ||
|
|
||
| val layoutParams = | ||
| LinearLayout.LayoutParams( | ||
| ViewGroup.LayoutParams.WRAP_CONTENT, |
There was a problem hiding this comment.
아마 indicator를 만들려고 binidngAdapter를 만든거 같은데, 이 부분은 tabLayout을 viewPager에 연결시켜서 커스텀하는게 코드가 더 깔끔한걸로 알고있어요!! 다음에 시간 날때 리팩터링 하면 좋을 것 같습니다!
There was a problem hiding this comment.
네네!! 다음에 리팩터링 진행하도록 하겠습니다!!
…riendogly into feature/dog_detail
jinuemong
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
2024-07-18.6.24.40.mov
전달 사항 (없으면 삭제해 주세요)
아직 도메인이 없어서 BindingAdapter에서 하드 코딩을 통한 분기처리를 진행했습니다.