Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] feat: Club 도메인 개발 #137

Merged
merged 14 commits into from
Jul 20, 2024
Merged

[BE] feat: Club 도메인 개발 #137

merged 14 commits into from
Jul 20, 2024

Conversation

jimi567
Copy link
Member

@jimi567 jimi567 commented Jul 20, 2024

이슈

개발 사항

  • club 도메인
  • 도메인 관련 VO 검증 로직
  • 이전 PR 리뷰 반영
  • local profile용 yml

jimi567 added 14 commits July 20, 2024 14:28
@jimi567
feat: club 도메인 추가
384561b 
- 필터링 값 제외하여 구현
@jimi567
refactor: @TeMPOraL 어노테이션 제거
acb0678
@jimi567
refactor: 예외 메세지 상수 활용하도록 변경
c218648
@jimi567
refactor: 상수명 변경
6fa7693
@jimi567
fix: 연관관계 수정
12e38d9
@jimi567
fix: h2예약어와 필드명 일치로 인한 버그 픽스
276888f 
- value 는 예약어라 별다른 column명을 지정해줘야됨
@jimi567
fix: VO 필드명 Embedded로 변경
9ed6ea8
@jimi567
chore: local용 profile 프로퍼티 추가
c6d8d88
@jimi567
feat: owner null 검증
e89a575
@jimi567
feat: ManyToMany 연관 관계 제거
c33d303 
- 추후 도메인 끼리 협의하여 연관 관계 설정
@jimi567
style: 어노테이션 선언순서 컨벤션에 맞도록 변경
d2b279d
@jimi567
style: Column name 옵션 적용
c500528
@jimi567
style: 컨벤션에 의거해 개행 제거
cb6e11c
@jimi567
test: 생성 테스트 경계값 테스트로 변경
d2c8993
@jimi567 jimi567 changed the title [BE] [BE] Club 도메인 개발 Jul 20, 2024
@github-actions GitHub Actions
Copy link

Unit Test Results

57 tests   57 ✔️  2s ⏱️
14 suites    0 💤
14 files      0 ❌

Results for commit d2c8993.

J-I-H-O
J-I-H-O approved these changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@J-I-H-O J-I-H-O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하네요 😊
고생하셨습니다~

@jimi567 jimi567 changed the title [BE] Club 도메인 개발 [BE] feat: Club 도메인 개발 Jul 20, 2024
@jimi567 jimi567 added 🖥 backend backend ✨ feat 기능 개발 labels Jul 20, 2024
@ehtjsv2 ehtjsv2 requested review from takoyakimchi and ehtjsv2 July 20, 2024 07:22
takoyakimchi
takoyakimchi approved these changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@takoyakimchi takoyakimchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 고생~!!!

@jimi567 jimi567 merged commit 1e89c4c into develop Jul 20, 2024
3 checks passed
@jimi567 jimi567 deleted the feature/club branch July 20, 2024 07:59
takoyakimchi pushed a commit that referenced this pull request Oct 23, 2024
@jimi567 @takoyakimchi
[BE] feat: Club 도메인 개발 (#137)
4ab2f4d
@jimi567 jimi567 self-assigned this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-I-H-O J-I-H-O J-I-H-O approved these changes

@ehtjsv2 ehtjsv2 ehtjsv2 approved these changes

@takoyakimchi takoyakimchi takoyakimchi approved these changes

Assignees

@jimi567 jimi567

Labels
🖥 backend backend ✨ feat 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimi567 @takoyakimchi @ehtjsv2 @J-I-H-O