Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AN] feat: 네트워크 통신 세팅 및 토큰 매니저 구현 #143

Merged
merged 9 commits into from
Jul 21, 2024
Merged

[AN] feat: 네트워크 통신 세팅 및 토큰 매니저 구현 #143

merged 9 commits into from
Jul 21, 2024

Conversation

junjange
Copy link
Member

@junjange junjange commented Jul 20, 2024 •
edited
Loading

이슈

개발 사항

  • 네트워크 통신 세팅
  • 토큰 매니저 구현
  • 의존성 관리 Module 구현

리뷰 요청 사항

  • 토큰 매니저(LocalModule)와 의존성 관리(AppModule)부분 위주로 확인해주시면 감사하겠습니다!

전달 사항

  • 현재까지 서버에서 제공된 API 명세를 기반으로 코드를 작성해 두었습니다. 아직 배포된 API는 아니기 때문에 필요에 따라 수정할 수 있음을 인지하고, 코드를 검토해 주시면 감사하겠습니다!!
  • 에러 처리에 대한 내용은 다같이 모여서 이야기하면 좋을 것 같습니다.

@junjange junjange added 🤖 android android ✨ feat 기능 개발 labels Jul 20, 2024
@junjange junjange added this to the Sprint2 milestone Jul 20, 2024
@junjange junjange self-assigned this Jul 20, 2024
@junjange junjange changed the title 네트워크 통신 세팅 [AN] feat: 네트워크 통신 세팅 및 토큰 매니저 구현 Jul 20, 2024
gaeun5744
gaeun5744 previously approved these changes Jul 20, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 20, 2024 •
edited
Loading

Test Results

3 tests  ±0   3 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit c4ee99e. ± Comparison against base commit 06bf0c1.

♻️ This comment has been updated with latest results.

gaeun5744
gaeun5744 approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@gaeun5744 gaeun5744 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당!!

dpcks0509
dpcks0509 approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@dpcks0509 dpcks0509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요오! 나도 통신쪽 하려고 만들어놓은거 있는데 내꺼 머지할때 왕창 터지겠다...ㅜ

@junjange junjange merged commit 4efa14b into develop Jul 21, 2024
2 checks passed
@junjange junjange deleted the feature/network-setting branch July 21, 2024 14:43
takoyakimchi pushed a commit that referenced this pull request Oct 23, 2024
@junjange @takoyakimchi
[AN] feat: 네트워크 통신 세팅 및 토큰 매니저 구현 (#143)
55e1e80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpcks0509 dpcks0509 dpcks0509 approved these changes

@gaeun5744 gaeun5744 gaeun5744 approved these changes

@jinuemong jinuemong Awaiting requested review from jinuemong jinuemong is a code owner

Assignees

@junjange junjange

Labels
🤖 android android ✨ feat 기능 개발
Projects
2024-friendogly
Status: Done
Milestone
Sprint2
Development

Successfully merging this pull request may close these issues.

네트워크 통신 세팅
3 participants
@junjange @gaeun5744 @dpcks0509