[BE] feat: 인증 ArgumentResolver 구현 및 API 문서화 #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owacourse-teams/2024-friendogly into feature/authorization-argumentResolve
jimi567
approved these changes
Jul 22, 2024
Comment on lines
+75
to
+78
| //tasks.withType(GenerateSwaggerUI) { | ||
| // dependsOn 'openapi3' | ||
| //} | ||
|
|
Comment on lines
+33
to
+35
| if (authorizationValue == null) { | ||
| throw new FriendoglyException("로그인 후에 사용할 수 있습니다."); | ||
| } |
There was a problem hiding this comment.
인증 관련된 예외는 따로 만들어도 좋을 것 같아요. 401
| @@ -29,8 +31,11 @@ public PetController(PetQueryService petQueryService, PetCommandService petComma | |||
| } | |||
|
|
|||
| @PostMapping | |||
| public ResponseEntity<SavePetResponse> savePet(@RequestBody @Valid SavePetRequest savePetRequest) { | |||
| SavePetResponse response = petCommandService.savePet(savePetRequest); | |||
| public ResponseEntity<SavePetResponse> savePet( | |||
ehtjsv2
approved these changes
Jul 22, 2024
| @@ -29,8 +31,11 @@ public PetController(PetQueryService petQueryService, PetCommandService petComma | |||
| } | |||
|
|
|||
| @PostMapping | |||
| public ResponseEntity<SavePetResponse> savePet(@RequestBody @Valid SavePetRequest savePetRequest) { | |||
| SavePetResponse response = petCommandService.savePet(savePetRequest); | |||
| public ResponseEntity<SavePetResponse> savePet( | |||
takoyakimchi
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
전달 사항
@Auth어노테이션 걸어주시면 ArgumentResolver가 Authorization 헤더에서 값 꺼내서 넣어줍니다.