Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] feat: 시간대 설정, 날짜 응답 포맷 일괄 지정 #175

Merged
merged 3 commits into from
Jul 23, 2024
Merged

[BE] feat: 시간대 설정, 날짜 응답 포맷 일괄 지정 #175

merged 3 commits into from
Jul 23, 2024

Conversation

takoyakimchi
Copy link
Contributor

@takoyakimchi takoyakimchi commented Jul 23, 2024 •
edited
Loading

이슈

개발 사항

  • 시간대를 대한민국 표준시인 Asia/Seoul 으로 지정
  • 프로덕션 코드와 문서화 테스트 코드에서, 날짜 응답 포맷을 다음과 같이 지정
    • LocalDate: yyyy-MM-dd
    • LocalTime: HH:mm:ss.SSS
    • LocalDateTime: yyyy-MM-dd HH:mm:ss.SSS
  • RestDocsTest에서 LocalDateTime을 제대로 문서화하지 못하였던 오류 수정
  • Footprint DTO 에서 불필요한 @JsonFormat 제거

전달 사항

  • AWS EC2에 배포 후 시간이 GMT+9 (한국 시간)으로 잘 설정되어있는지 확인 필요
  • 앞으로 시간을 사용하는 테스트를 작성할 때는 TimeZone을 꼭 명시해야 합니다! Service가 아닌 다른 layer에서도 추상 클래스를 적용시키면 더 안전하게 할 수 있을 것 같네요.

@takoyakimchi takoyakimchi linked an issue Jul 23, 2024 that may be closed by this pull request
Timezone 설정, 날짜 응답 포맷 설정 #174
Closed
@takoyakimchi takoyakimchi requested review from jimi567, ehtjsv2 and J-I-H-O and removed request for jimi567 and ehtjsv2 July 23, 2024 04:29
@takoyakimchi takoyakimchi self-assigned this Jul 23, 2024
@takoyakimchi takoyakimchi added 🧦 chore chore 🖥 backend backend ✨ feat 기능 개발 labels Jul 23, 2024
@takoyakimchi takoyakimchi added this to the Sprint2 milestone Jul 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

Unit Test Results

84 tests   84 ✔️  4s ⏱️
19 suites    0 💤
19 files      0 ❌

Results for commit e45ad51.

♻️ This comment has been updated with latest results.

ehtjsv2
ehtjsv2 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ehtjsv2 ehtjsv2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳

jimi567
jimi567 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@jimi567 jimi567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니당.

@takoyakimchi takoyakimchi merged commit 0b5edfd into develop Jul 23, 2024
3 checks passed
@takoyakimchi takoyakimchi deleted the feature/be/issue-174 branch July 23, 2024 10:47
takoyakimchi added a commit that referenced this pull request Oct 23, 2024
@takoyakimchi
[BE] feat: 시간대 설정, 날짜 응답 포맷 일괄 지정 (#175)
c1e441c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-I-H-O J-I-H-O J-I-H-O approved these changes

@ehtjsv2 ehtjsv2 ehtjsv2 approved these changes

@jimi567 jimi567 jimi567 approved these changes

Assignees

@takoyakimchi takoyakimchi

Labels
🖥 backend backend 🧦 chore chore ✨ feat 기능 개발
Projects
2024-friendogly
Status: Done
Milestone
Sprint2
Development

Successfully merging this pull request may close these issues.

Timezone 설정, 날짜 응답 포맷 설정
4 participants
@takoyakimchi @jimi567 @ehtjsv2 @J-I-H-O