프로필 만들기 API 연결 #177
Merged
프로필 만들기 API 연결 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results3 tests 3 ✅ 0s ⏱️ Results for commit 6b212dc. |
gaeun5744
previously approved these changes
Jul 23, 2024
Comment on lines
51
to
+62
| // data source | ||
| private val clubDataSource: ClubDataSource = ClubDataSourceImpl(service = clubService) | ||
| private val localDataSource: LocalDataSource = LocalDataSourceImpl(localModule = localModule) | ||
| private val kakaoLoginDataSource: KakaoLoginDataSource = KakaoLoginDataSourceImpl() | ||
| private val memberDataSource: MemberDataSource = MemberDataSourceImpl(service = memberService) | ||
|
|
||
| // repository | ||
| private val clubRepository: ClubRepository = ClubRepositoryImpl(source = clubDataSource) | ||
| private val localRepository: LocalRepository = LocalRepositoryImpl(source = localDataSource) | ||
| private val kakaoLoginRepository: KakaoLoginRepository = | ||
| KakaoLoginRepositoryImpl(dataSource = kakaoLoginDataSource) | ||
| private val memberRepository: MemberRepository = MemberRepositoryImpl(source = memberDataSource) |
There was a problem hiding this comment.
너무 과도하게 많아질 것 같아서, dataSourceModule과 RepositoryModule을 나눠도 좋을 것 같습니다!
| import com.woowacourse.friendogly.remote.model.response.MemberResponse | ||
|
|
||
| fun MemberResponse.toData(): MemberDto { | ||
| Log.d("ttt this", this.toString()) |
gaeun5744
approved these changes
Jul 23, 2024
jinuemong
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항