[BE] feat: s3를 프로젝트와 연동 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
takoyakimchi
approved these changes
Jul 24, 2024
backend/build.gradle
Outdated
Comment on lines
67
to
72
| swaggerUI 'org.webjars:swagger-ui:4.11.1' | ||
|
|
||
| implementation "software.amazon.awssdk:s3:2.26.21" | ||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
Suggested change
| swaggerUI 'org.webjars:swagger-ui:4.11.1' | |
| implementation "software.amazon.awssdk:s3:2.26.21" | |
| } | |
| swaggerUI 'org.webjars:swagger-ui:4.11.1' | |
| implementation "software.amazon.awssdk:s3:2.26.21" | |
| } |
Comment on lines
15
to
24
| public ImageController(FileStorageManager fileStorageManager) { | ||
| this.fileStorageManager = fileStorageManager; | ||
| } | ||
|
|
||
|
|
||
| @PostMapping("/test-upload") | ||
| public ResponseEntity<String> uploadFile(@RequestParam("file") MultipartFile file) { | ||
| String imageUrl = fileStorageManager.uploadFile(file); | ||
| return ResponseEntity.ok(imageUrl); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public ImageController(FileStorageManager fileStorageManager) { | |
| this.fileStorageManager = fileStorageManager; | |
| } | |
| @PostMapping("/test-upload") | |
| public ResponseEntity<String> uploadFile(@RequestParam("file") MultipartFile file) { | |
| String imageUrl = fileStorageManager.uploadFile(file); | |
| return ResponseEntity.ok(imageUrl); | |
| } | |
| public ImageController(FileStorageManager fileStorageManager) { | |
| this.fileStorageManager = fileStorageManager; | |
| } | |
| @PostMapping("/test-upload") | |
| public ResponseEntity<String> uploadFile(@RequestParam("file") MultipartFile file) { | |
| String imageUrl = fileStorageManager.uploadFile(file); | |
| return ResponseEntity.ok(imageUrl); | |
| } |
개행이 2줄이군요!!
예시 코드는 나중에 까먹지 않고 삭제할 수 있도록 TODO를 남겨도 좋을 것 같아요!
Comment on lines
5
to
8
| public interface FileStorageManager { | ||
|
|
||
| public String uploadFile(MultipartFile file); | ||
| } |
Comment on lines
37
to
41
| } | ||
|
|
||
| public String uploadFile(MultipartFile file) { | ||
| String key = file.getOriginalFilename(); | ||
|
|
There was a problem hiding this comment.
Suggested change
| } | |
| public String uploadFile(MultipartFile file) { | |
| String key = file.getOriginalFilename(); | |
| } | |
| @Override | |
| public String uploadFile(MultipartFile file) { | |
| String key = file.getOriginalFilename(); | |
없어도 잘 되겠지만, 오버라이드는 명시해주는 게 좋은 것 같아요.
Comment on lines
56
to
58
| } catch (Exception e) { | ||
| throw new FriendoglyException("MultipartFile의 임시 파일 생성 중 에러 발생"); | ||
| } |
There was a problem hiding this comment.
이 부분은 상태코드가 400이랑은 다르게 관리되겠네요!
FriendoglyException에 상태코드를 지정할 수 있는 생성자가 있어요.
takoyakimchi
previously approved these changes
Jul 24, 2024
Comment on lines
5
to
8
| public interface FileStorageManager { | ||
|
|
||
| public String uploadFile(MultipartFile file); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public interface FileStorageManager { | |
| public String uploadFile(MultipartFile file); | |
| } | |
| public interface FileStorageManager { | |
| String uploadFile(MultipartFile file); | |
| } |
Comment on lines
60
to
65
| try (FileOutputStream fos = new FileOutputStream(file)) { | ||
| fos.write(multipartFile.getBytes()); | ||
| fos.flush(); | ||
| } catch (Exception e) { | ||
| throw new FriendoglyException("MultipartFile to File 변환 중 오류 발생"); | ||
| } |
There was a problem hiding this comment.
Suggested change
| try (FileOutputStream fos = new FileOutputStream(file)) { | |
| fos.write(multipartFile.getBytes()); | |
| fos.flush(); | |
| } catch (Exception e) { | |
| throw new FriendoglyException("MultipartFile to File 변환 중 오류 발생"); | |
| } | |
| try (FileOutputStream fos = new FileOutputStream(file)) { | |
| fos.write(multipartFile.getBytes()); | |
| fos.flush(); | |
| } catch (IOException e) { | |
| throw new FriendoglyException("MultipartFile to File 변환 중 오류 발생"); | |
| } |
J-I-H-O
previously approved these changes
Jul 24, 2024
Comment on lines
+20
to
+27
| @Value("${aws.s3.bucket-name}") | ||
| private String BUCKET_NAME; | ||
|
|
||
| @Value("${aws.s3.server.endpoint}") | ||
| private String S3_ENDPOINT; | ||
|
|
||
| @Value("${aws.s3.server.key-prefix}") | ||
| private String KEY_PREFIX; |
There was a problem hiding this comment.
환경변수도 생성자 주입을 사용할 수 있다는 사실을 알고계신가요? (두둥)
There was a problem hiding this comment.
알고있어요! 근데 그거는 final을 붙여서 불변성을 유지하기 위함인가요?
J-I-H-O
approved these changes
Jul 24, 2024
dpcks0509
pushed a commit
that referenced
this pull request
Jul 24, 2024
takoyakimchi
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
리뷰 요청 사항 (없으면 삭제해 주세요)
전달 사항 (없으면 삭제해 주세요)