Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] test: Footprint 테스트에 픽스처 적용 #243

Merged
merged 2 commits into from
Jul 29, 2024
Merged

[BE] test: Footprint 테스트에 픽스처 적용 #243

merged 2 commits into from
Jul 29, 2024

Conversation

takoyakimchi
Copy link
Contributor

이슈

개발 사항

  • Footprint 테스트에서 Test Fixture 사용
  • 테스트 코드에 given, when, then 형식으로 주석 작성

@takoyakimchi takoyakimchi added this to the Sprint2 milestone Jul 28, 2024
@takoyakimchi takoyakimchi self-assigned this Jul 28, 2024
@takoyakimchi takoyakimchi linked an issue Jul 28, 2024 that may be closed by this pull request
Footprint 테스트에서 Test Fixture 사용 #227
Closed
@github-actions GitHub Actions
Copy link

Unit Test Results

92 tests   92 ✔️  5s ⏱️
20 suites    0 💤
20 files      0 ❌

Results for commit 7c46196.

jimi567
jimi567 approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@jimi567 jimi567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기능 구현이 어느정도 끝나면 테스트도 함께 리팩터링해봐요~

J-I-H-O
J-I-H-O approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@J-I-H-O J-I-H-O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔해서 좋네요~
개인적으로 따로 분리하는건 선호하지 않지만, 현재 테스트 대상은 발자국이고 member와 pet은 발자국을 생성하기 위한 선행 조건일 뿐인 만큼 따로 빼도 좋은 것 같아용~

@J-I-H-O J-I-H-O merged commit 6f18561 into develop Jul 29, 2024
3 checks passed
@J-I-H-O J-I-H-O deleted the feature/be/#227 branch July 29, 2024 04:50
takoyakimchi added a commit that referenced this pull request Oct 23, 2024
@takoyakimchi
[BE] test: Footprint 테스트에 픽스처 적용 (#243)
b04e109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-I-H-O J-I-H-O J-I-H-O approved these changes

@ehtjsv2 ehtjsv2 ehtjsv2 approved these changes

@jimi567 jimi567 jimi567 approved these changes

Assignees

@takoyakimchi takoyakimchi

Labels
🖥 backend backend 🔎 test 테스트
Projects
2024-friendogly
Status: Done
Milestone
Sprint2
Development

Successfully merging this pull request may close these issues.

Footprint 테스트에서 Test Fixture 사용
4 participants
@takoyakimchi @jimi567 @ehtjsv2 @J-I-H-O