[BE] refactor: 모임 주소 정보 요청 및 저장 방식 변경 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com> Co-authored-by: jimi567 <repday0609@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com> Co-authored-by: jimi567 <repday0609@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com> Co-authored-by: jimi567 <repday0609@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com> Co-authored-by: jimi567 <repday0609@gmail.com>
takoyakimchi
approved these changes
Aug 2, 2024
Comment on lines
+19
to
+23
| @Column(name = "city", nullable = false) | ||
| private String city; | ||
|
|
||
| @Column(name = "village", nullable = false) | ||
| private String village; |
Comment on lines
+21
to
+24
| public static Set<SizeType> toSizeTypes(Set<String> sizeType) { | ||
| return sizeType.stream() | ||
| .map(SizeType::toSizeType) | ||
| .collect(Collectors.toSet()); |
There was a problem hiding this comment.
Suggested change
| public static Set<SizeType> toSizeTypes(Set<String> sizeType) { | |
| return sizeType.stream() | |
| .map(SizeType::toSizeType) | |
| .collect(Collectors.toSet()); | |
| public static Set<SizeType> toSizeTypes(Set<String> sizeType) { | |
| return sizeType.stream() | |
| .map(SizeType::toSizeType) | |
| .collect(Collectors.toUnmodifiableSet()); |
불변 set으로 리턴하는 건 어떨까요?!
There was a problem hiding this comment.
놓친 부분이네요 approve 주셔서 추후에 수정하겠습니다.
ehtjsv2
approved these changes
Aug 4, 2024
takoyakimchi
pushed a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: jimi567 <repday0609@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
전달 사항
FriendoglyException이 발생해야 합니다. 하지만FriendoglyException이 아닌, bean validation의@NotEmpty에 걸리는 현상을 확인했습니다.