[BE] 주변 발자국 조회 hotfix & 더미데이터 추가 #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
ehtjsv2
requested review from
takoyakimchi,
J-I-H-O and
jimi567
and removed request for
takoyakimchi and
J-I-H-O
takoyakimchi
requested changes
Aug 5, 2024
Comment on lines
121
to
124
| @AfterEach | ||
| void setDown() { | ||
| footprintRepository.deleteAll(); | ||
| } |
There was a problem hiding this comment.
fyi
보통은 tearDown이라고 쓰는 것 같아요!!!
| @@ -43,6 +44,7 @@ void findOne() { | |||
| ); | |||
| } | |||
|
|
|||
| @Disabled | |||
There was a problem hiding this comment.
아예 삭제하거나, assert 문을 바꿔도 좋겠네요!
Comment on lines
59
to
62
| return recentFootprints.stream() | ||
| .filter(footprint -> footprint.isNear(currentLocation)) | ||
| .filter(footprint -> !footprint.isDeleted()) | ||
| .map(footprint -> new FindNearFootprintResponse(footprint, footprint.isCreatedBy(memberId))) |
There was a problem hiding this comment.
Suggested change
| return recentFootprints.stream() | |
| .filter(footprint -> footprint.isNear(currentLocation)) | |
| .filter(footprint -> !footprint.isDeleted()) | |
| .map(footprint -> new FindNearFootprintResponse(footprint, footprint.isCreatedBy(memberId))) | |
| return recentFootprints.stream() | |
| .filter(footprint -> !footprint.isDeleted() && footprint.isNear(currentLocation)) | |
| .map(footprint -> new FindNearFootprintResponse(footprint, footprint.isCreatedBy(memberId))) |
혹시라도 범위 내 조회가 부활한다면 이렇게 수정하면 좋을 것 같아요.
- filter를 중복으로 쓰면 불필요한 객체 생성이 일어나서 성능에 좋지 못해요. 참고 링크
- 조건 검사의 순서 이야기인데요. 나중에 데이터가 쌓이면 논리 삭제 되어 있는 발자국이, 그렇지 않은 발자국보다 많아질 것 같아요.
&&는 도도도 잘 아시겠지만 앞의 조건이 false이면 뒤 조건을 검사하지 않기 때문에,!isDeleted를 먼저 검사하도록 바꾸면 불필요한isNear검사가 줄어들 것 같네요!
J-I-H-O
previously approved these changes
Aug 6, 2024
| } | ||
|
|
||
| public boolean isNear(Location location) { | ||
| return this.location.isWithin(location, RADIUS_AS_METER); | ||
| return this.location.isWithin(location, NEAR_RADIUS_AS_METER); |
There was a problem hiding this comment.
조회 반경 제한을 없앤다면 해당 메서드도 제거해도 되지 않을까요?
There was a problem hiding this comment.
다시 부활할 가능성이 높다생각했기에 지우지않고 반경을 대한민국전체로 바꿨습니다
| FOOTPRINT_DELETED() | ||
| ) | ||
| ); | ||
| System.out.println(footprintRepository.findAll().size()); |
Test Results127 tests 127 ✅ 14s ⏱️ Results for commit 41b7ac3. ♻️ This comment has been updated with latest results. |
jimi567
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항