[AN] feat: FCM 구현 #312
Merged
[AN] feat: FCM 구현 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
junjange
reviewed
Aug 6, 2024
Comment on lines
1
to
9
| package com.happy.friendogly.data.source | ||
|
|
||
| interface SettingDataSource { | ||
| suspend fun saveAlarm(isSet: Boolean): Result<Unit> | ||
|
|
||
| suspend fun getAlarm(): Result<Boolean> | ||
|
|
||
| suspend fun deleteAlarm(): Result<Unit> | ||
| } |
There was a problem hiding this comment.
이게 어떤 DataSource일까요?!
use case를 사용하는 곳이 없어서 어디서, 어떻게 쓰이는지 감이 안오네요ㅠ
There was a problem hiding this comment.
다시 보니깐 네이밍이 모호하네요ㅠㅠ AlarmSetting으로 바꾸겠습니다!
Comment on lines
7
to
24
| class AlarmTokenDataSourceImpl( | ||
| private val alarmTokenModule: AlarmTokenModule, | ||
| ) : AlarmTokenDataSource { | ||
| override suspend fun getToken(): Result<String> = | ||
| runCatching { | ||
| alarmTokenModule.token.first() | ||
| } | ||
|
|
||
| override suspend fun saveToken(token: String): Result<Unit> = | ||
| runCatching { | ||
| alarmTokenModule.saveToken(token) | ||
| } | ||
|
|
||
| override suspend fun deleteToken(): Result<Unit> = | ||
| runCatching { | ||
| alarmTokenModule.deleteToken() | ||
| } | ||
| } |
There was a problem hiding this comment.
여기서 token은 아마 FCM Token일 것 같은데, 일반적으로? 앱에서 token을 저장한다고 하면 jwt를 저장한다고 생각 할 것 같아요! 이 부분에서 혼동이 있을 수 있으므로, 네이밍을 명확히 하는 것이 중요합니다.
There was a problem hiding this comment.
이 부분에 대해 궁금한 점이 있습니다! 혹시 객체 내 프로퍼티 or 메서드 네이밍 때문에 헷갈렸던 경험이 있을까요..?
해당 메서드는 AlarmToken 객체 내에 있기 때문에 헷갈릴 여지가 없다고 생각했습니다!
예를 들어서... intent는 4대 컴포넌트 모두에서 필요한 객체임에도 불구하고, Activity 내에 있는 intent는 Activity의 intent구나! 라고 알아서 인식하는 느낌...?
++ 프리코스 피드백 안에, 객체 지향 생활 체조 원칙 인용 글에도 관련 내용이 있어요!
저 가끔 프리코스 피드백 보면서 다시 되짚는 편인데, 지금봐도 유익한거 같네요 헤헤 강추강추
| import com.happy.friendogly.local.di.AlarmModule | ||
| import kotlinx.coroutines.flow.first | ||
|
|
||
| class SettingDataSourceImpl( |
| import kotlinx.coroutines.Dispatchers | ||
| import kotlinx.coroutines.launch | ||
|
|
||
| class AlarmReceiver : FirebaseMessagingService() { |
|
|
||
| private val key = stringPreferencesKey(FCM_TOKEN) | ||
|
|
||
| var token: Flow<String> = |
| import kotlinx.coroutines.Dispatchers | ||
| import kotlinx.coroutines.launch | ||
|
|
||
| class AlarmReceiver : FirebaseMessagingService() { |
jinuemong
approved these changes
Aug 14, 2024
junjange
approved these changes
Aug 14, 2024
takoyakimchi
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
전달 사항 (없으면 삭제해 주세요)