Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AN] 웹소켓 연결 #336

Merged
merged 13 commits into from
Aug 9, 2024
Merged

[AN] 웹소켓 연결 #336

merged 13 commits into from
Aug 9, 2024

Conversation

gaeun5744
Copy link
Member

이슈

개발 사항

  • 채팅 웹소켓 구현

전달 사항 (없으면 삭제해 주세요)

KakaoTalk_20240808_221956074.mp4

@gaeun5744 gaeun5744 requested review from junjange, jinuemong and dpcks0509 and removed request for junjange and jinuemong August 8, 2024 13:21
@gaeun5744 gaeun5744 self-assigned this Aug 8, 2024
@gaeun5744 gaeun5744 added 🤖 android android ✨ feat 기능 개발 labels Aug 8, 2024
@gaeun5744 gaeun5744 modified the milestone: Sprint3 Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

Test Results

3 tests   3 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit b9166a9.

♻️ This comment has been updated with latest results.

Copy link
Member

@junjange junjange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어려운 기능이였을 텐데 구현하시느라 고생하셨습니다!!

private val _chats: MutableLiveData<List<ChatListUiModel>> = MutableLiveData()
val chats: LiveData<List<ChatListUiModel>> get() = _chats

var memberId: Long = 0L
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public이여도 되나요?!

Copy link
Contributor

@jinuemong jinuemong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ! !

@gaeun5744 gaeun5744 merged commit 1d4be73 into develop Aug 9, 2024
2 checks passed
@gaeun5744 gaeun5744 deleted the feature/web-socket branch August 20, 2024 02:02
takoyakimchi pushed a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android android ✨ feat 기능 개발
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants