[AN] fix: 각종 에러 처리 + 리팩터링 #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinuemong
approved these changes
Aug 12, 2024
| @@ -41,7 +41,7 @@ class MainActivity : | |||
| } | |||
|
|
|||
| private fun initNavController() { | |||
| switchFragment(ClubListFragment::class.java) | |||
| supportFragmentManager.findFragmentById(R.id.nav_host_fragment_container) ?: switchFragment(ClubListFragment::class.java) | |||
There was a problem hiding this comment.
[mainActivity: nav 선택 위치와 띄워진 fragment가 동일하도록 구현]에 대한 fix인가요?
이유가 무엇이었을까요
There was a problem hiding this comment.
현재 container에 fragment가 있는지 없는지 확인하는 코드입니다! 해당 코드로 configuration change때 무분별하게 fragment가 switch되는 것을 막을 수 있습니다
junjange
reviewed
Aug 12, 2024
| @@ -12,7 +12,7 @@ fun ChatRoom.toUiModel(): ChatListUiModel = | |||
| "", | |||
| memberCount, | |||
| 0, | |||
| LocalDateTime.now().classifyChatDateTime(), | |||
| LocalDateTime.of(2024, 6, 7, 13, 6).classifyChatDateTime(), | |||
There was a problem hiding this comment.
아 일부러 더미데이터로 넣었습니다!! listAdapter 데이터 갱신 기준 확인할려구요
junjange
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
전달 사항 (없으면 삭제해 주세요)