Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AN] feat: 프로필 세팅 페이지 에러 핸들링 #414

Merged
merged 9 commits into from
Aug 16, 2024

Conversation

junjange
Copy link
Member

@junjange junjange commented Aug 15, 2024

이슈

개발 사항

  • 프로필 설정 에러 핸들링
  • 프로필 설정 시 로딩 화면 구현

@junjange junjange added 🤖 android android ✨ feat 기능 개발 labels Aug 15, 2024
@junjange junjange self-assigned this Aug 15, 2024
Copy link

github-actions bot commented Aug 15, 2024

Test Results

3 tests  ±0   3 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit d3b4385. ± Comparison against base commit b0a292f.

♻️ This comment has been updated with latest results.

Comment on lines 134 to 136
# loading
spinKit = { group = "com.github.ybq", name = "Android-SpinKit", version.ref = "spinKit" }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거는 #6기-기술검토 채널에서 허락받아야할 것 같네요.. 혹시 해당 라이브러리를 꼭 써야하나요?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하핳 자연스레 썼네옄ㅋㅋㅋㅋㅋ 수정하고 스크린샷 다시 첨부하도록 하겠습니다!!

@junjange junjange requested a review from gaeun5744 August 15, 2024 11:33
gaeun5744
gaeun5744 previously approved these changes Aug 15, 2024
Copy link
Member

@gaeun5744 gaeun5744 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많았어여~~~!!!!!

@jimi567
Copy link
Member

jimi567 commented Aug 16, 2024

고생하셧어요.~ 깔끔하네요

Copy link
Contributor

@dpcks0509 dpcks0509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요~~

@junjange junjange merged commit d149313 into develop Aug 16, 2024
2 checks passed
@junjange junjange deleted the feature/profile-setting-error-handling branch August 17, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android android ✨ feat 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

프로필 설정 에러 핸들링
4 participants