Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] refactor: ChatRoomController 공통 응답 적용 #437

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

takoyakimchi
Copy link
Contributor

@takoyakimchi takoyakimchi commented Aug 16, 2024

이슈

개발 사항

  • ChatRoomController에서 공통 응답이 적용되어 있지 않은 메서드가 있었음.
  • 이 부분에서 공통 응답 적용

리뷰 요청 사항

  • 큰 변경 사항 없어서 바로 approve 해주세요

전달 사항

  • ⚠️ 안드로이드 앱 업데이트하는 타이밍에 맞게 merge해야 합니다. ⚠️

@takoyakimchi takoyakimchi added this to the Sprint4 milestone Aug 16, 2024
@takoyakimchi takoyakimchi self-assigned this Aug 16, 2024
Copy link

Test Results

133 tests  +130   133 ✅ +130   15s ⏱️ +15s
 27 suites + 26     0 💤 ±  0 
 27 files   + 26     0 ❌ ±  0 

Results for commit 356f9f3. ± Comparison against base commit b0a292f.

This pull request removes 3 and adds 133 tests. Note that renamed tests count towards both.
com.happy.friendogly.ExampleUnitTest ‑ addition_isCorrect
com.happy.friendogly.ExampleUnitTest ‑ addition_isCorrect2
com.happy.friendogly.ExampleUnitTest ‑ addition_isCorrect3
com.happy.friendogly.chat.service.ChatRoomCommandServiceTest ‑ 1대1 채팅방 저장 과정에서, 이미 채팅방이 존재하면 기존 채팅방 ID를 반환한다.
com.happy.friendogly.chat.service.ChatRoomCommandServiceTest ‑ 모임에 참여하지 않은 경우, 모임 채팅방에서 나갈 수 없다.
com.happy.friendogly.chat.service.ChatRoomCommandServiceTest ‑ 새로운 1대1 채팅방을 개설할 수 있다.
com.happy.friendogly.chat.service.ChatRoomCommandServiceTest ‑ 채팅방에 참여한 경우, 채팅방에서 나갈 수 있다.
com.happy.friendogly.chat.service.ChatRoomQueryServiceTest ‑ 내가 속해 있는 채팅방을 찾을 수 있다.
com.happy.friendogly.chat.service.ChatRoomQueryServiceTest ‑ 자신이 참여한 채팅방이 아니면 채팅방에서 모임 정보를 받아올 수 없다.
com.happy.friendogly.chat.service.ChatRoomQueryServiceTest ‑ 채팅방 ID로부터 모임 ID, 허용 펫 사이즈, 허용 펫 성별을 조회할 수 있다.
com.happy.friendogly.chat.service.ChatRoomQueryServiceTest ‑ 채팅방 내 멤버 세부정보를 조회할 수 있다.
com.happy.friendogly.club.domain.AddressTest ‑ [1] provinceInput=null
com.happy.friendogly.club.domain.AddressTest ‑ [2] provinceInput=
…

@gaeun5744 gaeun5744 merged commit 89d0fda into develop Aug 20, 2024
3 checks passed
@takoyakimchi takoyakimchi deleted the feature/be/#436 branch August 21, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

채팅 공통 응답 적용
5 participants