[AN] refactor: 모임 등록 & 강아지 선택 UI 개선 #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaeun5744
reviewed
Aug 16, 2024
| @@ -110,6 +115,13 @@ class PetSelectBottomSheet( | |||
| R.string.dog_select_load_fail, | |||
| ), | |||
| ) | |||
|
|
|||
| PetSelectEvent.PreventCommit -> | |||
There was a problem hiding this comment.
Commit이라는 네이밍이 개발적인 용어라서, 로직이 연상되지 않네요
PreventComplete나 PreventFinish는 어떤가요?!
There was a problem hiding this comment.
좋습니다 !
TODO 달아놨는데, 다음 Pr에 수정해서 요청할게요
gaeun5744
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
111.mp4