Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] feat: 로그아웃 기능 구현 #440

Merged
merged 6 commits into from
Aug 16, 2024
Merged

[BE] feat: 로그아웃 기능 구현 #440

merged 6 commits into from
Aug 16, 2024

Conversation

J-I-H-O
Copy link
Contributor

@J-I-H-O J-I-H-O commented Aug 16, 2024

이슈

개발 사항

  • 로그아웃 API 구현

전달 사항

  • 로그아웃 시 DB에 저장된 refresh token을 null로 업데이트 하도록 구현했습니다.
  • 카카오 로그아웃도 구현 후 로컬에서 테스트도 완료했으나, 카카오 로그아웃이 정말 필요한가 의논이 필요한 것 같아 호출하는 부분을 주석처리 해두었습니다.

@J-I-H-O J-I-H-O added 🖥 backend backend ✨ feat 기능 개발 labels Aug 16, 2024
@J-I-H-O J-I-H-O self-assigned this Aug 16, 2024
Copy link

github-actions bot commented Aug 16, 2024

Test Results

137 tests  +134   137 ✅ +134   16s ⏱️ +16s
 28 suites + 27     0 💤 ±  0 
 28 files   + 27     0 ❌ ±  0 

Results for commit 1b39a28. ± Comparison against base commit d149313.

This pull request removes 3 and adds 137 tests. Note that renamed tests count towards both.
com.happy.friendogly.ExampleUnitTest ‑ addition_isCorrect
com.happy.friendogly.ExampleUnitTest ‑ addition_isCorrect2
com.happy.friendogly.ExampleUnitTest ‑ addition_isCorrect3
com.happy.friendogly.chat.service.ChatRoomCommandServiceTest ‑ 1대1 채팅방 저장 과정에서, 이미 채팅방이 존재하면 기존 채팅방 ID를 반환한다.
com.happy.friendogly.chat.service.ChatRoomCommandServiceTest ‑ 모임에 참여하지 않은 경우, 모임 채팅방에서 나갈 수 없다.
com.happy.friendogly.chat.service.ChatRoomCommandServiceTest ‑ 새로운 1대1 채팅방을 개설할 수 있다.
com.happy.friendogly.chat.service.ChatRoomCommandServiceTest ‑ 채팅방에 참여한 경우, 채팅방에서 나갈 수 있다.
com.happy.friendogly.chat.service.ChatRoomQueryServiceTest ‑ 내가 속해 있는 채팅방을 찾을 수 있다.
com.happy.friendogly.chat.service.ChatRoomQueryServiceTest ‑ 자신이 참여한 채팅방이 아니면 채팅방에서 모임 정보를 받아올 수 없다.
com.happy.friendogly.chat.service.ChatRoomQueryServiceTest ‑ 채팅방 ID로부터 모임 ID, 허용 펫 사이즈, 허용 펫 성별을 조회할 수 있다.
com.happy.friendogly.chat.service.ChatRoomQueryServiceTest ‑ 채팅방 내 멤버 세부정보를 조회할 수 있다.
com.happy.friendogly.club.domain.AddressTest ‑ [1] provinceInput=null
com.happy.friendogly.club.domain.AddressTest ‑ [2] provinceInput=
…

♻️ This comment has been updated with latest results.

takoyakimchi
takoyakimchi previously approved these changes Aug 16, 2024
Copy link
Contributor

@takoyakimchi takoyakimchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완벽(칸페키)하네요

Copy link
Member

@jimi567 jimi567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 마무리 해주셨네요 페어를 해서 그런지 땡이의 코드가 정말 읽기편하네요.ㅎㅎ

Copy link
Member

@jimi567 jimi567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 마무리 해주셨네요 페어를 해서 그런지 땡이의 코드가 정말 읽기편하네요.ㅎㅎ

Copy link
Contributor

@ehtjsv2 ehtjsv2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳

@J-I-H-O J-I-H-O merged commit 7926e9b into develop Aug 16, 2024
3 checks passed
@J-I-H-O J-I-H-O deleted the feature/logout branch August 16, 2024 11:07
ehtjsv2 pushed a commit that referenced this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥 backend backend ✨ feat 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

회원 로그아웃 API
4 participants