[AN] feat: 회원가입 에러 핸들링 #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riendogly into feature/register-error-handling
jinuemong
previously approved these changes
Aug 17, 2024
gaeun5744
previously approved these changes
Aug 17, 2024
| @@ -6,4 +6,6 @@ sealed interface RegisterMessage { | |||
| data object ServerErrorMessage : RegisterMessage | |||
There was a problem hiding this comment.
저는 이런 공통된 에러 메시지가, 상속을 통해 해결해야 하는 반복 로직 중 하나라고 생각해요..! (BaseViewModel 뿐만이 아니라, Network Interface 등으로 해결하는 경우 포함)
다음에는 domain적인 에러와 ui적인 에러를 어떻게 분리하면 좋을까? 도 고민하면 좋을것 같습니다!
gaeun5744
approved these changes
Aug 17, 2024
jinuemong
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항