Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AN] refactor: 모임 참여 로직 개선 #457

Merged
merged 7 commits into from
Aug 19, 2024
Merged

[AN] refactor: 모임 참여 로직 개선 #457

merged 7 commits into from
Aug 19, 2024

Conversation

jinuemong
Copy link
Contributor

이슈

개발 사항

  • 강아지 미등록 시 모임 참여에 대한 로직을 수정합니다.
  • 모임 참여 시 채팅으로 이동하는 로직을 적용합니다.

전달 사항

  • 서버와 api 맞출 부분이 있어서 TODO 달았습니다.

@jinuemong jinuemong added 🛠️ refactor 리팩터링 🤖 android android ✨ feat 기능 개발 labels Aug 18, 2024
@jinuemong jinuemong self-assigned this Aug 18, 2024
@github-actions GitHub Actions
Copy link

Test Results

3 tests  ±0   3 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit d395038. ± Comparison against base commit 80634f8.

gaeun5744
gaeun5744 approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@gaeun5744 gaeun5744 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당~

junjange
junjange approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@junjange junjange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿!! 고생하셨습니다~~👍

@jinuemong jinuemong merged commit 454f838 into develop Aug 19, 2024
2 checks passed
@jinuemong jinuemong deleted the refactor/club-participation branch August 20, 2024 02:02
takoyakimchi pushed a commit that referenced this pull request Oct 23, 2024
@jinuemong @takoyakimchi
[AN] refactor: 모임 참여 로직 개선 (#457)
e4ac8bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaeun5744 gaeun5744 gaeun5744 approved these changes

@junjange junjange junjange approved these changes

@dpcks0509 dpcks0509 Awaiting requested review from dpcks0509 dpcks0509 is a code owner

Assignees

@jinuemong jinuemong

Labels
🤖 android android ✨ feat 기능 개발 🛠️ refactor 리팩터링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

모임 참여 로직 개선
3 participants
@jinuemong @junjange @gaeun5744