Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AN] v0.4.1 QA 유저 관련 이슈 #635

Merged
merged 5 commits into from
Oct 11, 2024
Merged

[AN] v0.4.1 QA 유저 관련 이슈 #635

merged 5 commits into from
Oct 11, 2024

Conversation

junjange
Copy link
Member

@junjange junjange commented Oct 9, 2024

이슈

개발 사항

  • 강아지 네이밍 공통화
  • 강아지 등록 완료시, 등록 완료! 라는 문구 수정
  • 강아지 생성 → 생일 미래 날짜 관련
  • 상대 유저 프로필 페이지 햄버거 바 수정

전달 사항

"댕댕이 사진을 추가하세요 → 사진 추가 인식 범위 너무 넓어요" 라는 이슈는 한번 더 이야기 해보면 좋을 것 같아 반영하지 않았습니다.

@junjange junjange added 🐞 bug 버그 수정 🤖 android android labels Oct 9, 2024
@junjange junjange self-assigned this Oct 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

Test Results

43 tests   43 ✅  1s ⏱️
 5 suites   0 💤
 5 files     0 ❌

Results for commit a4964b3.

♻️ This comment has been updated with latest results.

gaeun5744
gaeun5744 requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@gaeun5744 gaeun5744 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

브랜치명이 에띠네요
코멘트 확인해주시면 감사하겠습니다! 짱 수고하셨어요~

...n/java/com/happy/friendogly/presentation/ui/registerpet/bottom/EditPetBirthdayBottomSheet.kt
maxValue = MAX_MONTH
maxValue = currentMonth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게하면 올해가 아닌 년도에도 적용되지않나요?
2023년 11월이 안되는것 같습니다ㅠㅠ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉,, 그러네여,,,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다~~

jinuemong
jinuemong previously approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@jinuemong jinuemong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !!! 깔끔하네요

jinuemong
jinuemong approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@jinuemong jinuemong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳 로직 오류도 해결되었군요

gaeun5744
gaeun5744 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@gaeun5744 gaeun5744 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넘 잘 고쳤다!! 짱이다!!

@junjange junjange merged commit 38e2a33 into develop Oct 11, 2024
2 checks passed
@junjange junjange deleted the fix/v0.4.1-eddy branch October 11, 2024 07:35
takoyakimchi pushed a commit that referenced this pull request Oct 23, 2024
@junjange @takoyakimchi
[AN] v0.4.1 QA 유저 관련 이슈 (#635)
7e22723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaeun5744 gaeun5744 gaeun5744 approved these changes

@jinuemong jinuemong jinuemong approved these changes

@dpcks0509 dpcks0509 Awaiting requested review from dpcks0509 dpcks0509 is a code owner

Assignees

@junjange junjange

Labels
🤖 android android 🐞 bug 버그 수정
Projects
2024-friendogly
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.4.1 QA 유저 관련 이슈
3 participants
@junjange @jinuemong @gaeun5744