Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AN] test: RegisterPetViewModel 테스트 #655

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

junjange
Copy link
Member

이슈

개발 사항

  • RegisterPetViewModel 테스트

@junjange junjange added 🔎 test 테스트 🤖 android android labels Oct 14, 2024
@junjange junjange self-assigned this Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

Test Results

49 tests   49 ✅  1s ⏱️
 6 suites   0 💤
 6 files     0 ❌

Results for commit ffd4554.

♻️ This comment has been updated with latest results.

gaeun5744
gaeun5744 previously approved these changes Oct 17, 2024
Copy link
Member

@gaeun5744 gaeun5744 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당~


var profileImageUrl: String? = null
private var _neutering = MutableLiveData(true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var

Comment on lines +119 to +120
android:onTextChanged="@{(s, start, before, count) -> vm.updatePetName(s)}"
android:text="@{vm.petName}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backing property로 숨기기 위해 이렇게 onTextChange를 활용하신 건가요??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞아요!!

Copy link
Contributor

@dpcks0509 dpcks0509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 작성 좋아요!! 고생하셨습니다~

Copy link
Member

@gaeun5744 gaeun5744 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

히히 리뷰 반영 고생하셨어여

@junjange junjange merged commit 4e128ed into develop Oct 17, 2024
2 checks passed
@junjange junjange deleted the test/RegisterPetViewModel-test branch October 17, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android android 🔎 test 테스트
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RegisterPetViewModel 테스트
3 participants