Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AN] fix : 모임 3차 요구사항 개선 #669

Merged
merged 4 commits into from
Oct 18, 2024
Merged

[AN] fix : 모임 3차 요구사항 개선 #669

merged 4 commits into from
Oct 18, 2024

Conversation

jinuemong
Copy link
Contributor

@jinuemong jinuemong added 🤹 enhance 성능 개선 🤖 android android labels Oct 17, 2024
@jinuemong jinuemong self-assigned this Oct 17, 2024
Copy link

Test Results

62 tests  ±0   62 ✅ ±0   1s ⏱️ ±0s
 9 suites ±0    0 💤 ±0 
 9 files   ±0    0 ❌ ±0 

Results for commit bc987e3. ± Comparison against base commit 065ddcd.

Copy link
Member

@junjange junjange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~

Copy link
Contributor

@dpcks0509 dpcks0509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

Comment on lines +164 to +181
android:id="@+id/include_add_club_female"
layout="@layout/include_pet_filter_menu"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginEnd="5dp"
android:layout_marginBottom="5dp"
app:actionHandler="@{vm}"
app:filterName="@{ClubFilter.NEUTRALIZING_FEMALE_NAME}" />
app:filterName="@{ClubFilter.FEMALE_NAME}" />

<include
android:id="@+id/include_add_club_female"
android:id="@+id/include_add_club_neutralizing_male"
layout="@layout/include_pet_filter_menu"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginEnd="5dp"
android:layout_marginBottom="5dp"
app:actionHandler="@{vm}"
app:filterName="@{ClubFilter.FEMALE_NAME}" />
app:filterName="@{ClubFilter.NEUTRALIZING_MALE_NAME}" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

필터 순서 수정 편안~

@jinuemong jinuemong merged commit 3dc7dc9 into develop Oct 18, 2024
2 checks passed
@jinuemong jinuemong deleted the fix/club branch November 4, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android android 🤹 enhance 성능 개선
Projects
None yet
3 participants