Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] 모임 예외 처리 추가 #705

Merged
merged 2 commits into from
Oct 23, 2024
Merged

[BE] 모임 예외 처리 추가 #705

merged 2 commits into from
Oct 23, 2024

Conversation

J-I-H-O
Copy link
Contributor

@J-I-H-O J-I-H-O commented Oct 23, 2024

이슈

개발 사항

  • club status가 FULL일 때 OPEN으로 변경할 수 없도록 수정
  • club 참여 시 status 검증 추가

전달 사항

  • 일관성을 위해, 정원이 가득찬 모임인지 여부 판별 시 clubMember size 대신 status를 사용하도록 변경했습니다.

@J-I-H-O J-I-H-O added 🐞 bug 버그 수정 🖥 backend backend labels Oct 23, 2024
@J-I-H-O J-I-H-O self-assigned this Oct 23, 2024
@J-I-H-O J-I-H-O changed the title [BE] Fix/club status update validation [BE] 모임 예외 처리 추가 Oct 23, 2024
jimi567
jimi567 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@jimi567 jimi567 left a comment •
edited by J-I-H-O
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 좋아요!!! 고생하셨습니다!

@github-actions GitHub Actions
Copy link

Test Results

223 tests   223 ✅  19s ⏱️
 46 suites    0 💤
 46 files      0 ❌

Results for commit 3cffdd9.

ehtjsv2
ehtjsv2 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@ehtjsv2 ehtjsv2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

takoyakimchi
takoyakimchi approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@takoyakimchi takoyakimchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 확인했습니다. 고생했어요

@J-I-H-O J-I-H-O merged commit ae0cbef into develop Oct 23, 2024
3 checks passed
@J-I-H-O J-I-H-O deleted the fix/club-status-update-validation branch October 23, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehtjsv2 ehtjsv2 ehtjsv2 approved these changes

@takoyakimchi takoyakimchi takoyakimchi approved these changes

@jimi567 jimi567 jimi567 approved these changes

Assignees

@J-I-H-O J-I-H-O

Labels
🖥 backend backend 🐞 bug 버그 수정
Projects
None yet
Milestone
No milestone
4 participants
@J-I-H-O @jimi567 @takoyakimchi @ehtjsv2