[AN] 놀이터 전체 조회 -> 범위 조회로 변경 #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpcks0509
requested review from
jinuemong,
junjange and
gaeun5744
as code owners
jinuemong
previously approved these changes
Jan 3, 2025
| @@ -957,7 +976,7 @@ class PlaygroundFragment : Fragment(), OnMapReadyCallback { | |||
| companion object { | |||
| private const val PLAYGROUND_RADIUS = 150.0 | |||
| private const val MIN_ZOOM = 7.0 | |||
| private const val DEFAULT_ZOOM = 15.0 | |||
| private const val DEFAULT_ZOOM = 14.0 | |||
There was a problem hiding this comment.
원래는 놀이터 전체를 한번에 불러와서 지도 줌이 더 많이 되어 있어도 지도 카메라를 이동하면 옆에 있는 놀이터들을 확인할 수 있었어요. 그런데 내가 보고 있는 화면의 범위를 토대로 놀이터를 조회해서 화면에 보여주기 때문에 초기에 사용자가 친구 찾기 기능에 접속했을때 지도 줌을 낮춤으로서 조금 더 많은 놀이터를 확인할 수 있도록 유도하였습니다!
junjange
previously approved these changes
Jan 3, 2025
Comment on lines
27
to
34
| suspend fun getPlaygrounds( | ||
| startLatitude: Double, | ||
| endLatitude: Double, | ||
| startLongitude: Double, | ||
| endLongitude: Double, | ||
| ): Result<List<Playground>> | ||
|
|
||
| suspend fun getMyPlayground(): DomainResult<MyPlayground, DataError.Network> |
There was a problem hiding this comment.
getPlaygrounds의 반환타입을 DomainResult로 안하신 이유가 있으실까요?
There was a problem hiding this comment.
앗 그렇네요 DomainResult로 수정해야하는 걸 빼먹었네요. 수정하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
시연 영상
1.1.mp4