[AN] feat: 강아지 선택 기능 구현 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results3 tests 3 ✅ 0s ⏱️ Results for commit e84afd2. ♻️ This comment has been updated with latest results. |
gaeun5744
previously approved these changes
Jul 17, 2024
Comment on lines
5
to
9
| data class DogSelectUiModel( | ||
| val id: Long, | ||
| val name: String, | ||
| val profileImage: String, | ||
| ) : Serializable { |
There was a problem hiding this comment.
혹시 @serializable로 바꿀 수 있을까요? import java에서 kotlin으로 하는게 안정성 면에서 좋을거 같아서요..!
|
머싯당 |
dpcks0509
approved these changes
Jul 18, 2024
Comment on lines
+26
to
+35
| private fun loadMyDogs() = | ||
| viewModelScope.launch { | ||
| delay(1000) | ||
| _dogs.value = | ||
| listOf( | ||
| DogSelectUiModel( | ||
| id = 0L, | ||
| profileImage = "", | ||
| name = "강아지 1", | ||
| ), |
There was a problem hiding this comment.
실제 데이터 로드에 대한 대비를하기 위해서입니다!
추후에 상태 관리에 대한 코드를 위해 작성하였습니다.
jinuemong
added a commit
that referenced
this pull request
Jul 19, 2024
takoyakimchi
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
Screen_recording_20240717_150555.mp4