[FE] 시간 선택 옵션 수정 #188
Merged
[FE] 시간 선택 옵션 수정 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results5 tests 5 ✅ 3s ⏱️ Results for commit ba87530. ♻️ This comment has been updated with latest results. |
hw0603
approved these changes
Aug 8, 2024
Yoonkyoungme
approved these changes
Aug 8, 2024
Comment on lines
35
to
36
| // 시간상 24시는 존재하지 않기 때문에 백엔드에서 오류가 발생. 따라서 24시일 때, 00:00시로 표현하기로 합의(@낙타) | ||
| times.push({ value: `${String(i === 24 ? 0 : i).padStart(2, '0')}:00`, label: label + ':00' }); |
There was a problem hiding this comment.
[P3]
좀 더 명확하게 설명하기 위해
00:00시로 표현하기로 합의 -> 오전 12:00으로 표현하지만, 서버에 00:00으로 전송 이라고 변경하는건 어떨까요?
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 세세한 빙봉...
hwinkr
approved these changes
Aug 8, 2024
Comment on lines
35
to
36
| // 시간상 24시는 존재하지 않기 때문에 백엔드에서 오류가 발생. 따라서 24시일 때, 00:00시로 표현하기로 합의(@낙타) | ||
| times.push({ value: `${String(i === 24 ? 0 : i).padStart(2, '0')}:00`, label: label + ':00' }); |
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 세세한 빙봉...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
특이 사항
리뷰 요구사항 (선택)