-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: 애플 로그인 API 문서화 #954
docs: 애플 로그인 API 문서화 #954
Conversation
Test Results 64 files ±0 64 suites ±0 13s ⏱️ ±0s Results for commit 25b375d. ± Comparison against base commit 848b444. This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
📝 Test Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐹 간단한 코멘트 남겼습니다~ 꼭 확인해주세요!
String nickname, | ||
|
||
@Schema(description = "프로필 사진 url", example = "imageurl") | ||
String imageUrl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[제안]
member의 imageUrl이 not null이라 칼럼을 nullable하게 바꾸거나
요청을 not null하게 강제해야 할 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
애플 로그인은 카카오와 다르게 프로필 사진을 제공해주지 않아 내부 로직이 개발되면 imageUrl은 nullable로 변경될 예정입니다!
꼼꼼하게 리뷰해주는 조조 고마워요 🐥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
별다른 리뷰 사안이 없어 바로 approve 하겠습니다! 간단한 코멘트에 대해선 확인해보시고 반영은 제리에 의사에 맡기겠습니다~
@NotNull | ||
String nickname, | ||
|
||
@Schema(description = "프로필 사진 url", example = "imageurl") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그럼 스키마 상에서 표기해주는 건 어떨까요?
@Schema(description = "프로필 사진 url", example = "imageurl") | |
@Schema(description = "프로필 사진 url", example = "imageurl", nullable =true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public record AppleAuthRequest( | ||
|
||
@Schema(description = "디바이스 토큰", example = "devicetokendevicetoken") | ||
@NotNull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blank 관련 체크도 광범위하게 잡아주어도 좋을 것 같아요. null 뿐만 아니라 "", " "에도 오류가 발생합니다.
@NotNull | |
@NotBlank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[반영] 25b375d (닉네임을 제외한 필드에 NotBlank를 적용했습니다)
🚩 연관 이슈
close #950
📝 작업 내용
POST /v1/auth/apple
request body: (*는 필수)
response code: 200
🏞️ 스크린샷 (선택)
🗣️ 리뷰 요구사항 (선택)
노션에는 따로 업데이트 안 했습니다. 해놓을까요?