Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] feat: 리뷰 링크 관리 페이지와 라우터 설정 추가 #1032

Merged
merged 11 commits into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions frontend/src/components/layouts/Footer/style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ export const Footer = styled.footer`

background-color: ${({ theme }) => theme.colors.white};

border-top: 0.1rem solid ${({ theme }) => theme.colors.lightGray};

${media.xSmall} {
flex-direction: column;
gap: 0.2rem;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,11 @@ import styled from '@emotion/styled';
import media from '@/utils/media';

export const Logo = styled.div`
line-height: 8rem;
text-align: center;

span {
font-size: 3rem;
font-size: 2.8rem;
font-weight: ${({ theme }) => theme.fontWeight.bolder};
letter-spacing: 0.7rem;

${media.small} {
font-size: 2.8rem;
}

${media.xSmall} {
Comment on lines 5 to 12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존 로고 컴포넌트가 Topbar의 padding 때문에 영역을 벗어났는데, 해결되었네요👍🏻

font-size: 2.6rem;
Expand Down
1 change: 1 addition & 0 deletions frontend/src/constants/amplitudeEventName.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export const PAGE_VISITED_EVENT_NAME: { [key in Exclude<PageName, undefined>]: s
detailedReview: '[page] 리뷰 상세 보기 페이지',
reviewWriting: '[page] 리뷰 작성 페이지',
reviewWritingComplete: '[page] 리뷰 작성 완료 페이지',
reviewLinkManagement: '[page] 리뷰 링크 관리 페이지',
Copy link
Contributor

@BadaHertz52 BadaHertz52 Jan 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세심하게, Amplitude도 챙겼네요 👍

Amplitude에서 접속한 페이지 경로를 추적하려면, ROUTE에 'reviewLinkManagement' 를 key로 하는 경로도 추가되어야해요.

};

export const REVIEW_WRITING_EVENT_NAME = {
Expand Down
1 change: 1 addition & 0 deletions frontend/src/constants/route.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ export const ROUTE = {
detailedReview: 'user/detailed-review',
reviewZone: 'user/review-zone',
reviewCollection: 'user/review-collection',
reviewLinkManagement: 'user/review-link-management',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL의 경우, 개인적으로 간단하게 user/review-linksuser/my-review-links 같은 느낌도 괜찮을 것 같아요!

Copy link
Contributor Author

@soosoo22 soosoo22 Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

훨씬 좋은 것 같네요!👍👍
일단 이 부분은 회의를 통해서 확정을 지어야 할 것 같아서 추후에 변경할게요!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 간결하게 가져가는 게 좋다고 생각합니다! 그래서 작성한 리뷰 확인 페이지도 바꿨어요. (이것도 바꾸라는 건 아님!)

};
27 changes: 27 additions & 0 deletions frontend/src/pages/ReviewLinkManagementPage/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import ReviewCard from '@/components/ReviewCard';

import { URLGeneratorForm } from '../HomePage/components';

import * as S from './styles';

const ReviewLinkManagementPage = () => {
return (
<S.Layout>
<S.LeftContainer>
<URLGeneratorForm />
</S.LeftContainer>
<S.Separator />
<S.RightContainer>
<S.TitleWrapper>
<h2>생성한 리뷰 링크를 확인해보세요</h2>
<S.SubTitle>클릭하면 해당 프로젝트의 리뷰 목록으로 이동해요</S.SubTitle>
</S.TitleWrapper>
<S.ReviewLinkList>
<ReviewCard createdAt={''} contentPreview={''} categories={[]} handleClick={() => {}} />
</S.ReviewLinkList>
</S.RightContainer>
</S.Layout>
);
};

export default ReviewLinkManagementPage;
66 changes: 66 additions & 0 deletions frontend/src/pages/ReviewLinkManagementPage/styles.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
import styled from '@emotion/styled';

import media from '@/utils/media';

export const Layout = styled.section`
width: 100%;

display: flex;

${media.small} {
flex-direction: column;

padding: 0 3rem;
}
`;

export const LeftContainer = styled.div`
width: 30%;

padding: 10rem 0;

${media.small} {
width: 100%;
}
`;

export const Separator = styled.div`
width: 0.1rem;
min-height: calc(100vh - 13rem); // 전체 영역에서 헤더와 푸터 영역 제외

background-color: ${({ theme }) => theme.colors.lightGray};

margin: 0 10rem;

${media.small} {
display: none;
}
`;

export const RightContainer = styled.div`
display: flex;
flex-direction: column;
gap: 3rem;

width: 70%;

padding: 10rem 0;

${media.small} {
width: 100%;
}
`;

export const TitleWrapper = styled.div`
display: flex;
flex-direction: column;
gap: 0.8rem;
`;

export const SubTitle = styled.span`
color: ${({ theme }) => theme.colors.gray};
/* font-size: ${({ theme }) => theme.fontSize.small}; */
/* font-weight: ${({ theme }) => theme.fontWeight.semibold}; */
`;

export const ReviewLinkList = styled.div``;
1 change: 1 addition & 0 deletions frontend/src/pages/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ export { default as ReviewWritingPage } from './ReviewWritingPage';
export { default as ReviewWritingCompletePage } from './ReviewWritingCompletePage';
export { default as ReviewZonePage } from './ReviewZonePage';
export { default as ReviewCollectionPage } from './ReviewCollectionPage';
export { default as ReviewLinkManagementPage } from './ReviewLinkManagementPage';
2 changes: 2 additions & 0 deletions frontend/src/router.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const ReviewWritingPage = lazy(() => import('@/pages/ReviewWritingPage'));
const ReviewZonePage = lazy(() => import('@/pages/ReviewZonePage'));
const ReviewCollectionPage = lazy(() => import('@/pages/ReviewCollectionPage'));
const LoadingPage = lazy(() => import('@/pages/LoadingPage'));
const ReviewLinkManagementPage = lazy(() => import('@/pages/ReviewLinkManagementPage'));

import App from './App';
import { ErrorSuspenseContainer } from './components';
Expand Down Expand Up @@ -52,6 +53,7 @@ const router = createBrowserRouter([
),
},
{ path: `${ROUTE.reviewCollection}/:${ROUTE_PARAM.reviewRequestCode}`, element: <ReviewCollectionPage /> },
{ path: `${ROUTE.reviewLinkManagement}`, element: <ReviewLinkManagementPage /> },
],
},
]);
Expand Down
Loading