Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] feat: 리뷰 도메인 구체화, 정책 구현 #43

Merged
merged 21 commits into from
Jul 19, 2024
Merged

[BE] feat: 리뷰 도메인 구체화, 정책 구현 #43

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
2cec5a0
feat: dto 검증을 위한 의존성 추가
nayonsoso Jul 18, 2024
6c3b497
feat: dto에 jakarta validation 어노테이션 추가
nayonsoso Jul 18, 2024
646f042
feat: 컨트롤러에서 요청을 검증할 수 있도록 설정
nayonsoso Jul 18, 2024
2544410
feat: FieldError 내용을 보여줄 응답 객체 생성
nayonsoso Jul 18, 2024
1e824d8
feat: FieldError 핸들러 추가
nayonsoso Jul 18, 2024
49ad199
refactor: 문자열 공백 검증을 위해 NotBlank 사용
nayonsoso Jul 18, 2024
c72c688
style: todo 주석 추가
nayonsoso Jul 18, 2024
588293c
feat: 데드라인이 지나면 리뷰를 작성할 수 없도록 하는 기능 추가
nayonsoso Jul 18, 2024
799d07a
refactor: 사이즈 검증문 제거
nayonsoso Jul 19, 2024
1e23d86
style: 개행 변경
nayonsoso Jul 19, 2024
9979f36
refactor: 예외 이름을 과거형으로 변경
nayonsoso Jul 19, 2024
c1ec4ef
refactor: RFC 9457 형식을 지키면서 필드 에러 정보를 반환하도록 수정
nayonsoso Jul 19, 2024
2602e99
chore: 오타 수정
nayonsoso Jul 19, 2024
5836e41
[FE] design: theme ,전역 스타일을 설정 (#41)
BadaHertz52 Jul 18, 2024
c995ae4
[FE] ci: 리액트 쿼리 및 msw 설치, eslint import rule 추가 및 적용 (#44)
soosoo22 Jul 18, 2024
7a18dc4
fix: conflict 해결
nayonsoso Jul 19, 2024
a3732a3
feat: dto에 jakarta validation 어노테이션 추가
nayonsoso Jul 18, 2024
0705980
refactor: 문자열 공백 검증을 위해 NotBlank 사용
nayonsoso Jul 18, 2024
eea60b2
refactor: 사이즈 검증문 제거
nayonsoso Jul 19, 2024
2497cd5
style: 컨벤션에 맞게 코드 정렬
nayonsoso Jul 19, 2024
097c5e1
Merge branch 'develop' into be/feature/36-review-domain-policy
nayonsoso Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backend/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ repositories {
dependencies {
implementation 'org.springframework.boot:spring-boot-starter-web'
implementation 'org.springframework.boot:spring-boot-starter-data-jpa'
implementation 'org.springframework.boot:spring-boot-starter-validation'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 커밋 메시지는 build:로 시작했으면 좋았겠네요 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉.. 동의합니다. 다음부터는 build 로 하겠습니다😥

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시.. 저희 커밋 구글 컨벤션으로 하기로 했는데 빌드 관련 커밋은 chore가 아니라 build로 하나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

구글 커밋 컨벤션에는 build 가 없군요!
그런데 저희 회의록에 의하면 build 쓰기로 했어서 그냥 써도 될 것 같아요 ㅎㅎ


runtimeOnly 'com.h2database:h2'
runtimeOnly 'com.mysql:mysql-connector-j'
Expand Down