[BE] feat: 리뷰어 그룹 도메인 구체화, 정책 구현

backend/src/main/java/reviewme/global/exception/UnAuthorizedException.java

@@ -0,0 +1,8 @@
+package reviewme.global.exception;
+
+public abstract class UnAuthorizedException extends ReviewMeException {
+
+    protected UnAuthorizedException(String errorMessage) {
+        super(errorMessage);
+    }
+}

backend/src/main/java/reviewme/member/domain/GithubReviewerGroup.java

@@ -0,0 +1,36 @@
+package reviewme.member.domain;
+
+import jakarta.persistence.Column;
+import jakarta.persistence.Entity;
+import jakarta.persistence.GeneratedValue;
+import jakarta.persistence.GenerationType;
+import jakarta.persistence.Id;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToOne;
+import jakarta.persistence.Table;
+import lombok.AccessLevel;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+
+@Entity
+@Table(name = "github_reviewer_group")
+@NoArgsConstructor(access = AccessLevel.PROTECTED)
+@Getter
+public class GithubReviewerGroup {
+
+    @Id
+    @GeneratedValue(strategy = GenerationType.IDENTITY)
+    private Long id;
+
+    @Column(name = "github_id", nullable = false)
+    private String githubId;
+
+    @ManyToOne
+    @JoinColumn(name = "reviewer_group_id")
+    private ReviewerGroup reviewerGroup;
+
+    public GithubReviewerGroup(String githubId, ReviewerGroup reviewerGroup) {
+        this.githubId = githubId;
+        this.reviewerGroup = reviewerGroup;
+    }
+}

backend/src/main/java/reviewme/member/domain/Member.java

@@ -23,7 +23,11 @@ public class Member {
     @Column(name = "name", nullable = false)
     private String name;
 
-    public Member(String name) {
+    @Column(name = "github_id", nullable = false)
+    private String githubId;
+
+    public Member(String name, String githubId) {
         this.name = name;
+        this.githubId = githubId;
     }
 }

backend/src/main/java/reviewme/member/repository/GithubReviewerGroupRepository.java

@@ -0,0 +1,12 @@
+package reviewme.member.repository;
+
+import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.stereotype.Repository;
+import reviewme.member.domain.GithubReviewerGroup;
+import reviewme.member.domain.ReviewerGroup;
+
+@Repository
+public interface GithubReviewerGroupRepository extends JpaRepository<GithubReviewerGroup, Long> {
+
+    boolean existsByGithubIdAndReviewerGroup(String githubId, ReviewerGroup reviewerGroup);
+}

backend/src/main/java/reviewme/review/domain/Review.java

@@ -6,7 +6,6 @@
 import jakarta.persistence.Id;
 import jakarta.persistence.JoinColumn;
 import jakarta.persistence.ManyToOne;
-import jakarta.persistence.OneToOne;
 import jakarta.persistence.Table;
 import lombok.AccessLevel;
 import lombok.Getter;
@@ -24,7 +23,7 @@ public class Review {
     @GeneratedValue(strategy = GenerationType.IDENTITY)
     private Long id;
 
-    @OneToOne
+    @ManyToOne
     @JoinColumn(name = "reviewer_id", nullable = false)
     private Member reviewer;
 

backend/src/main/java/reviewme/review/exception/GithubReviewerGroupUnAuthorizedException.java

@@ -0,0 +1,10 @@
+package reviewme.review.exception;
+
+import reviewme.global.exception.UnAuthorizedException;
+
+public class GithubReviewerGroupUnAuthorizedException extends UnAuthorizedException {
+
+    public GithubReviewerGroupUnAuthorizedException() {
+        super("리뷰어 그룹에 등록되지 않은 github 사용자입니다.");
+    }
+}

backend/src/main/java/reviewme/review/exception/ReviewAlreadySubmittedException.java

@@ -0,0 +1,10 @@
+package reviewme.review.exception;
+
+import reviewme.global.exception.BadRequestException;
+
+public class ReviewAlreadySubmittedException extends BadRequestException {
+
+    public ReviewAlreadySubmittedException() {
+        super("이미 리뷰를 작성한 경우 리뷰를 작성할 수 없습니다.");
+    }
+}

backend/src/main/java/reviewme/review/repository/ReviewRepository.java

@@ -3,11 +3,15 @@
 import jakarta.persistence.EntityNotFoundException;
 import org.springframework.data.jpa.repository.JpaRepository;
 import org.springframework.stereotype.Repository;
+import reviewme.member.domain.Member;
+import reviewme.member.domain.ReviewerGroup;
 import reviewme.review.domain.Review;
 
 @Repository
 public interface ReviewRepository extends JpaRepository<Review, Long> {
 
+    boolean existsByReviewerAndReviewerGroup(Member reviewer, ReviewerGroup reviewerGroup);
+
     default Review getReviewById(Long id) {
         return findById(id).orElseThrow(EntityNotFoundException::new);
     }

backend/src/main/java/reviewme/review/service/ReviewService.java

@@ -12,6 +12,7 @@
 import reviewme.member.domain.ReviewerGroup;
 import reviewme.member.dto.response.MemberResponse;
 import reviewme.member.dto.response.ReviewerGroupResponse;
+import reviewme.member.repository.GithubReviewerGroupRepository;
 import reviewme.member.repository.MemberRepository;
 import reviewme.member.repository.ReviewerGroupRepository;
 import reviewme.review.domain.Review;
@@ -21,6 +22,8 @@
 import reviewme.review.dto.request.CreateReviewRequest;
 import reviewme.review.dto.response.ReviewContentResponse;
 import reviewme.review.dto.response.ReviewResponse;
+import reviewme.review.exception.GithubReviewerGroupUnAuthorizedException;
+import reviewme.review.exception.ReviewAlreadySubmittedException;
 import reviewme.review.repository.ReviewContentRepository;
 import reviewme.review.repository.ReviewKeywordRepository;
 import reviewme.review.repository.ReviewRepository;
@@ -32,6 +35,7 @@ public class ReviewService {
     private final ReviewRepository reviewRepository;
     private final MemberRepository memberRepository;
     private final ReviewerGroupRepository reviewerGroupRepository;
+    private final GithubReviewerGroupRepository githubReviewerGroupRepository;
     private final ReviewContentRepository reviewContentRepository;
     private final KeywordRepository keywordRepository;
     private final ReviewKeywordRepository reviewKeywordRepository;
@@ -40,7 +44,19 @@ public class ReviewService {
     public Long createReview(CreateReviewRequest request) {
         Member reviewer = memberRepository.getMemberById(request.reviewerId());
         ReviewerGroup reviewerGroup = reviewerGroupRepository.getReviewerGroupById(request.reviewerGroupId());
+
+        boolean isValidReviewer = githubReviewerGroupRepository.existsByGithubIdAndReviewerGroup(
+                reviewer.getGithubId(),
+                reviewerGroup
+        );
+        if (!isValidReviewer) {
+            throw new GithubReviewerGroupUnAuthorizedException();
+        }
+        if (reviewRepository.existsByReviewerAndReviewerGroup(reviewer, reviewerGroup)) {
+            throw new ReviewAlreadySubmittedException();
+        }
         validateIsDeadlinePassed(reviewerGroup);
+
         Review review = reviewRepository.save(new Review(reviewer, reviewerGroup));
 
         List<ReviewContent> contents = request.contents()

backend/src/test/java/reviewme/member/domain/ReviewerGroupTest.java

@@ -15,7 +15,7 @@ class ReviewerGroupTest {
     @Test
     void 리뷰_그룹이_올바르게_생성된다() {
         // given
-        Member sancho = new Member("산초");
+        Member sancho = new Member("산초", "sancho");
         String groupName = "a".repeat(100);
         String description = "a".repeat(50);
         LocalDateTime createdAt = LocalDateTime.of(2024, 7, 17, 12, 0);
@@ -29,7 +29,7 @@ class ReviewerGroupTest {
     void 리뷰_그룹_이름_길이_제한을_벗어나는_경우_예외를_발생한다(int length) {
         // given
         String groupName = "a".repeat(length);
-        Member sancho = new Member("산초");
+        Member sancho = new Member("산초", "sancho");
         LocalDateTime createdAt = LocalDateTime.of(2024, 7, 17, 12, 0);
         // when, then
         assertThatThrownBy(() -> new ReviewerGroup(sancho, groupName, "설명", createdAt))
@@ -40,7 +40,7 @@ class ReviewerGroupTest {
     void 리뷰_그룹_설명_길이_제한을_벗어나는_경우_예외를_발생한다() {
         // given
         String description = "a".repeat(51);
-        Member sancho = new Member("산초");
+        Member sancho = new Member("산초", "sancho");
         LocalDateTime createdAt = LocalDateTime.of(2024, 7, 17, 12, 0);
         // when, then
         assertThatThrownBy(() -> new ReviewerGroup(sancho, "그룹 이름", description, createdAt))

backend/src/test/java/reviewme/review/ReviewServiceTest.java

@@ -9,15 +9,20 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import reviewme.keyword.domain.Keyword;
 import reviewme.keyword.repository.KeywordRepository;
+import reviewme.member.domain.GithubReviewerGroup;
 import reviewme.member.domain.Member;
 import reviewme.member.domain.ReviewerGroup;
+import reviewme.member.repository.GithubReviewerGroupRepository;
 import reviewme.member.repository.MemberRepository;
 import reviewme.member.repository.ReviewerGroupRepository;
 import reviewme.review.domain.Review;
 import reviewme.review.domain.exception.DeadlineExpiredException;
 import reviewme.review.dto.request.CreateReviewContentRequest;
 import reviewme.review.dto.request.CreateReviewRequest;
 import reviewme.review.dto.response.ReviewResponse;
+import reviewme.review.exception.GithubReviewerGroupUnAuthorizedException;
+import reviewme.review.exception.ReviewAlreadySubmittedException;
+import reviewme.review.repository.ReviewContentRepository;
 import reviewme.review.repository.ReviewRepository;
 import reviewme.review.service.ReviewService;
 import reviewme.support.ServiceTest;
@@ -37,17 +42,24 @@ class ReviewServiceTest {
     @Autowired
     ReviewerGroupRepository reviewerGroupRepository;
 
+    @Autowired
+    GithubReviewerGroupRepository githubReviewerGroupRepository;
+
     @Autowired
     KeywordRepository keywordRepository;
 
+    @Autowired
+    ReviewContentRepository reviewContentRepository;
+
     @Test
     void 리뷰를_작성한다() {
         // given
-        memberRepository.save(new Member("산초"));
-        Member reviewee = memberRepository.save(new Member("아루"));
-        reviewerGroupRepository.save(
-                new ReviewerGroup(reviewee, "그룹A", "그룹 설명", LocalDateTime.of(2099, 1, 1, 1, 1))
+        memberRepository.save(new Member("산초", "sancho"));
+        Member reviewee = memberRepository.save(new Member("아루", "aru"));
+        ReviewerGroup reviewerGroup = reviewerGroupRepository.save(
+                new ReviewerGroup(reviewee, "그룹A", "그룹 설명", LocalDateTime.of(2024, 1, 1, 1, 1))
         );
+        githubReviewerGroupRepository.save(new GithubReviewerGroup("sancho", reviewerGroup));
         Keyword keyword1 = keywordRepository.save(new Keyword("꼼꼼해요"));
         Keyword keyword2 = keywordRepository.save(new Keyword("친절해요"));
 
@@ -75,9 +87,9 @@ class ReviewServiceTest {
     @Test
     void 리뷰를_조회한다() {
         // given
-        Member reviewer = memberRepository.save(new Member("테드"));
-        Member reviewee = memberRepository.save(new Member("아루"));
-        memberRepository.save(new Member("산초"));
+        Member reviewer = memberRepository.save(new Member("테드", "ted"));
+        Member reviewee = memberRepository.save(new Member("아루", "aru"));
+        memberRepository.save(new Member("산초", "sancho"));
         ReviewerGroup reviewerGroup = reviewerGroupRepository.save(new ReviewerGroup(
                 reviewee,
                 "그룹A",
@@ -95,6 +107,57 @@ class ReviewServiceTest {
     }
 
     @Test
+    void 리뷰어_그룹에_속하지_않는_리뷰어가_리뷰를_작성할_경우_예외를_발생한다() {
+        // given
+        Member reviewee = memberRepository.save(new Member("아루", "aru"));
+        Member reviewer = memberRepository.save(new Member("테드", "ted"));
+        ReviewerGroup reviewerGroup = reviewerGroupRepository.save(new ReviewerGroup(
+                reviewee,
+                "그룹A",
+                "그룹 설명",
+                LocalDateTime.of(2024, 1, 1, 1, 1))
+        );
+        githubReviewerGroupRepository.save(new GithubReviewerGroup("kirby", reviewerGroup));
+
+        CreateReviewRequest createReviewRequest = new CreateReviewRequest(
+                reviewer.getId(),
+                reviewerGroup.getId(),
+                List.of(),
+                List.of()
+        );
+
+        // when, then
+        assertThatThrownBy(() -> reviewService.createReview(createReviewRequest))
+                .isInstanceOf(GithubReviewerGroupUnAuthorizedException.class);
+    }
+
+    @Test
+    void 이미_작성한_리뷰가_있는데_리뷰를_작성할_경우_예외를_발생한다() {
+        // given
+        Member reviewee = memberRepository.save(new Member("아루", "aru"));
+        Member reviewer = memberRepository.save(new Member("테드", "ted"));
+        ReviewerGroup reviewerGroup = reviewerGroupRepository.save(new ReviewerGroup(
+                reviewee,
+                "그룹A",
+                "그룹 설명",
+                LocalDateTime.of(2024, 1, 1, 1, 1))
+        );
+        githubReviewerGroupRepository.save(new GithubReviewerGroup("ted", reviewerGroup));
+
+        CreateReviewRequest createReviewRequest = new CreateReviewRequest(
+                reviewer.getId(),
+                reviewerGroup.getId(),
+                List.of(),
+                List.of()
+        );
+
+        reviewRepository.save(new Review(reviewer, reviewerGroup));
+
+        // when, then
+        assertThatThrownBy(() -> reviewService.createReview(createReviewRequest))
+                .isInstanceOf(ReviewAlreadySubmittedException.class);
+    }
+
     void 데드라인이_지난_리뷰그룹에_대해_리뷰를_작성하려하면_예외가_발생한다() {
         // given
         memberRepository.save(new Member("산초"));