[BE] refactor: 서비스 리팩터링 #540
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,6 +38,7 @@ public ReviewDetailResponse mapToReviewDetailResponse(Review review, ReviewGroup | |
| List<Section> sections = sectionRepository.findAllByTemplateId(templateId); | ||
| List<SectionAnswerResponse> sectionResponses = sections.stream() | ||
| .map(section -> mapToSectionResponse(review, reviewGroup, section)) | ||
| .filter(sectionResponse -> !sectionResponse.questions().isEmpty()) | ||
|
There was a problem hiding this comment. Dto라도 이런 질문은 던져도 괜찮다고 생각해요~!~! There was a problem hiding this comment. 만들어진 sectionResponse의 질문들이 없는 경우를 거르고 있는데 이 부분은 왜 필요한 건지 궁금해요! There was a problem hiding this comment. @donghoony 반영 완료👍 |
||
| .toList(); | ||
|
|
||
| return new ReviewDetailResponse( | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
응답 객체를 생성한다는 책임이 분리되어 서비스는 좀 더 흐름적인 부분에 집중, mapper 객체는 repo와 교류하며 응답생성. 이렇게 응집도가 올라가네요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍👍👌