Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] fix: 객관식 문항의 최소, 최대 선택 개수가 같은 경우 문구 추가 #563

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

chysis
Copy link
Contributor

@chysis chysis commented Sep 4, 2024


🚀 어떤 기능을 구현했나요 ?

  • 객관식 문항의 최소, 최대 선택 개수가 같은 경우, '1개 ~ 1개`의 형식이 아닌 '1개' 형식의 문구를 추가했습니다.

🔥 어떻게 해결했나요 ?

  • 최소, 최대가 같은 경우를 추가했습니다.

📝 어떤 부분에 집중해서 리뷰해야 할까요?

📚 참고 자료, 할 말

@@ -22,6 +22,7 @@ const QnABox = ({ question }: QnABoxProps) => {

const isAllSelectAvailable = maxCount === optionGroup.options.length;
if (!maxCount || isAllSelectAvailable) return `(최소 ${minCount}개 이상)`;
if (minCount === maxCount) return `(${maxCount}개)`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😋

Copy link
Contributor

@BadaHertz52 BadaHertz52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꾿!!! 👍

Copy link
Contributor

@ImxYJL ImxYJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아좋아~~~~

Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에프이! 빠르게 반영했네요 수고했어요!

개인적으로 사알짝 드는 생각이 PR을 구체적으로 명시해주면 좋을 것 같아요!!👍 물론 평소에는 자세하게 적어주긴 하지만요!
최대, 최소 개수가 같을 경우에 기존에 "1개 ~ 1개"가 아닌 "1개"로 나오게끔 문구를 추가했습니다."처럼 구체적으로 적어주면 좋을 것 같아요!!

@chysis chysis merged commit facf345 into develop Sep 4, 2024
6 checks passed
@donghoony donghoony deleted the fe/fix/562-checkbox branch September 26, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FE] 체크박스 선택 가능 개수의 최솟값과 최댓값이 같을 때 출력 형식을 바꾼다.
5 participants