[BE] refactor: 필수 질문이 아닌 경우 최소 글자수 제한 제거 #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimprodp
changed the title
donghoony
approved these changes
Sep 10, 2024
| } | ||
|
|
||
| if (!question.isRequired() && answerLength > MAX_LENGTH) { | ||
| throw new InvalidTextAnswerLengthException(question.getId(), answerLength, ZERO_LENGTH, MAX_LENGTH); |
There was a problem hiding this comment.
로그에서만 사용되는 것이라면 Exception(QuestionId, length, maxLength) 생성자를 만들어 min이 0일 때로 사용하면 어떨까요?
nayonsoso
approved these changes
Sep 14, 2024
Comment on lines
+31
to
+35
| if (question.isRequired() && (answerLength < MIN_LENGTH || answerLength > MAX_LENGTH)) { | ||
| throw new InvalidTextAnswerLengthException(question.getId(), answerLength, MIN_LENGTH, MAX_LENGTH); | ||
| } | ||
|
|
||
| if (!question.isRequired() && answerLength > MAX_LENGTH) { |
Comment on lines
+52
to
+58
| @Test | ||
| void 선택_질문의_답변_길이가_유효하지_않으면_예외가_발생한다() { | ||
| // given | ||
| String content = "답".repeat(10001); | ||
| Question savedQuestion = questionRepository.save(서술형_옵션_질문()); | ||
| TextAnswer textAnswer = new TextAnswer(savedQuestion.getId(), content); | ||
|
|
donghoony
deleted the
be/refactor/453-optional-text-question-min-length
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?
🔥 어떻게 해결했나요 ?
📝 어떤 부분에 집중해서 리뷰해야 할까요?
📚 참고 자료, 할 말