[FE] fix : ErrorPage과 App의 레이아웃(=DOM 구조)다른 오류 수정 #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 삭제된 컴포넌트: Sidebar, SidebarOpenButtion
- Topbar, BreadCrumb, Main 추가 - children으로 필요한 Main의 하위 컴포넌트 받도록 함 - BreadCrumb 필요에 따라 화면에 보여지도록 props 추가
ImxYJL
approved these changes
Sep 15, 2024
|
|
||
| const ErrorPage = () => { | ||
| const { isSidebarHidden, isSidebarModalOpen, closeSidebar, openSidebar } = useSidebar(); |
There was a problem hiding this comment.
레벨 3 초기에 사이드바 열심히 만들던 게 엊그제같은데...(비록 제가 만들진 않았지만...) 시간이 빠르네요 ㅠ_ㅠ
There was a problem hiding this comment.
🥲그때 진짜 빨리 구현하느라고 ... 고생했죠
| @@ -3,12 +3,12 @@ import { EssentialPropsWithChildren } from '@/types'; | |||
| import * as S from './styles'; | |||
|
|
|||
| interface MainProps { | |||
| isBreadCrumb?: boolean; | |||
| isShowBreadCrumb?: boolean; | |||
soosoo22
approved these changes
Sep 15, 2024
chysis
approved these changes
Sep 15, 2024
Comment on lines
+15
to
+26
| const PageLayout = ({ children, isNeedBreadCrumb = true }: EssentialPropsWithChildren<PageLayoutProps>) => { | ||
| const breadcrumbPathList = useBreadcrumbPaths(); | ||
| const isShowBreadCrumb = isNeedBreadCrumb && breadcrumbPathList.length > 1; | ||
|
|
||
| return ( | ||
| <S.Layout> | ||
| <S.Wrapper>{children}</S.Wrapper> | ||
| <S.Wrapper> | ||
| <Topbar /> | ||
| {isShowBreadCrumb && <Breadcrumb pathList={breadcrumbPathList} />} | ||
| <Main isShowBreadCrumb={isShowBreadCrumb}>{children}</Main> | ||
| <Footer /> | ||
| </S.Wrapper> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?
수정이유
🔥 어떻게 해결했나요 ?
📝 어떤 부분에 집중해서 리뷰해야 할까요?
📚 참고 자료, 할 말