Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] fix: Brotli 압축 플러그인 교체 #704

Merged
merged 4 commits into from
Sep 26, 2024
Merged

[FE] fix: Brotli 압축 플러그인 교체 #704

merged 4 commits into from
Sep 26, 2024

Conversation

BadaHertz52
Copy link
Contributor

🚀 어떤 기능을 구현했나요 ?

  • 현재 BrotliPlugin으로 Brotli 압축을 하고 있어요 그런데 해당 플러그인 사용 시 DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated.라는 경고 문구가 떴어요. Webpack의 내부 API 중 Compilation.assets에 대한 변경 방식이 앞으로 달라질 것인데 BrotliPlugin에서 이를 사용하는 것으로 추측해요. 당장은 문제가 되지 않지만, 경고를 발견했을 때 수정하는 게 맞다생각해 수정했어요

🔥 어떻게 해결했나요 ?

-Brotli로 압축하는 플러그인을 compression-webpack-plugin으로 변경했어요

📝 어떤 부분에 집중해서 리뷰해야 할까요?

📚 참고 자료, 할 말

@BadaHertz52 BadaHertz52 added this to the 5차 스프린트 milestone Sep 26, 2024
@BadaHertz52 BadaHertz52 self-assigned this Sep 26, 2024
@BadaHertz52 BadaHertz52 linked an issue Sep 26, 2024 that may be closed by this pull request
[FE] Brotli 압축 플러그인 교체 #702
Closed
@BadaHertz52 BadaHertz52 changed the title [FE] fix: 압축 플러그인 교체 [FE] fix: Brotli 압축 플러그인 교체 Sep 26, 2024
ImxYJL
ImxYJL approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@ImxYJL ImxYJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

chysis
chysis approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@chysis chysis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했습니다!

soosoo22
soosoo22 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요 바다!

@BadaHertz52 BadaHertz52 merged commit 2f10463 into develop Sep 26, 2024
1 check passed
@BadaHertz52 BadaHertz52 deleted the fe/fix/702_brotli branch September 26, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImxYJL ImxYJL ImxYJL approved these changes

@soosoo22 soosoo22 soosoo22 approved these changes

@chysis chysis chysis approved these changes

Assignees

@BadaHertz52 BadaHertz52

Labels
🍀 FE
Projects
2024-review-me
Status: Done
Milestone
5차 스프린트
Development

Successfully merging this pull request may close these issues.

[FE] Brotli 압축 플러그인 교체
4 participants
@BadaHertz52 @chysis @soosoo22 @ImxYJL